Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify purpose of parameters allow_redirects, max_redirects for ClientSession.request (and related functions) #10283

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

asrelo
Copy link
Contributor

@asrelo asrelo commented Dec 31, 2024

Pull request as suggested by @Dreamsorcerer at #10282

Is it a substantial burden for the maintainers to support this?

There is now more information about effects of these parameters in the docs. I assume I understood the intent behind them, and their joint behavior isn't a subject to change a lot.

Related issue number

Fixes #10282

Checklist

N/A

I could not build the docs to verify changes.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (16e7f91) to head (688662b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10283      +/-   ##
==========================================
- Coverage   98.78%   98.77%   -0.01%     
==========================================
  Files         122      122              
  Lines       37029    37029              
  Branches     2041     2041              
==========================================
- Hits        36579    36576       -3     
- Misses        311      314       +3     
  Partials      139      139              
Flag Coverage Δ
CI-GHA 98.66% <ø> (-0.01%) ⬇️
OS-Linux 98.34% <ø> (-0.01%) ⬇️
OS-Windows 96.25% <ø> (ø)
OS-macOS 97.46% <ø> (-0.01%) ⬇️
Py-3.10.11 97.35% <ø> (ø)
Py-3.10.15 97.92% <ø> (ø)
Py-3.11.11 98.01% <ø> (-0.01%) ⬇️
Py-3.11.9 97.43% <ø> (ø)
Py-3.12.8 98.44% <ø> (ø)
Py-3.13.1 98.43% <ø> (ø)
Py-3.9.13 97.24% <ø> (+<0.01%) ⬆️
Py-3.9.20 97.80% <ø> (-0.01%) ⬇️
Py-pypy7.3.16 97.39% <ø> (ø)
VM-macos 97.46% <ø> (-0.01%) ⬇️
VM-ubuntu 98.34% <ø> (-0.01%) ⬇️
VM-windows 96.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 31, 2024

CodSpeed Performance Report

Merging #10283 will not alter performance

Comparing asrelo:docs-clarify-redirects-params (688662b) with master (16e7f91)

Summary

✅ 47 untouched benchmarks

@Dreamsorcerer Dreamsorcerer added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Dec 31, 2024
@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Dec 31, 2024
@Dreamsorcerer
Copy link
Member

I could not build the docs to verify changes.

You can just follow the details link next to the RTD CI item once it's run.

@Dreamsorcerer Dreamsorcerer merged commit e5d6016 into aio-libs:master Dec 31, 2024
41 checks passed
Copy link
Contributor

patchback bot commented Dec 31, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/e5d6016c8054a9b31f777e01bd400aa26bd6730d/pr-10283

Backported as #10284

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Dec 31, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/e5d6016c8054a9b31f777e01bd400aa26bd6730d/pr-10283

Backported as #10285

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 31, 2024
…`ClientSession.request` (and related functions) (#10283)

(cherry picked from commit e5d6016)
Dreamsorcerer pushed a commit that referenced this pull request Dec 31, 2024
…low_redirects`, `max_redirects` for `ClientSession.request` (and related functions) (#10285)

**This is a backport of PR #10283 as merged into master
(e5d6016).**

Co-authored-by: asrelo <47759736+asrelo@users.noreply.github.com>
Dreamsorcerer pushed a commit that referenced this pull request Dec 31, 2024
…low_redirects`, `max_redirects` for `ClientSession.request` (and related functions) (#10284)

**This is a backport of PR #10283 as merged into master
(e5d6016).**

Co-authored-by: asrelo <47759736+asrelo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
2 participants