-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify purpose of parameters allow_redirects
, max_redirects
for ClientSession.request
(and related functions)
#10283
Clarify purpose of parameters allow_redirects
, max_redirects
for ClientSession.request
(and related functions)
#10283
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10283 +/- ##
==========================================
- Coverage 98.78% 98.77% -0.01%
==========================================
Files 122 122
Lines 37029 37029
Branches 2041 2041
==========================================
- Hits 36579 36576 -3
- Misses 311 314 +3
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10283 will not alter performanceComparing Summary
|
You can just follow the details link next to the RTD CI item once it's run. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10284 🤖 @patchback |
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10285 🤖 @patchback |
Pull request as suggested by @Dreamsorcerer at #10282
Is it a substantial burden for the maintainers to support this?
There is now more information about effects of these parameters in the docs. I assume I understood the intent behind them, and their joint behavior isn't a subject to change a lot.
Related issue number
Fixes #10282
Checklist
N/A
I could not build the docs to verify changes.