-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused type ignores and casts #1031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There's a few things to address to make this mergeable.
Looks like the 3.10 and 3.8 runs also need |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
=======================================
Coverage 62.60% 62.60%
=======================================
Files 38 38
Lines 6721 6721
Branches 368 368
=======================================
Hits 4208 4208
Misses 2486 2486
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
skip label added as a workaround since the bot is currently not working as expected |
mypy already got updated so I removed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hauntsaninja
Are there changes in behavior for the user?
No
Checklist