Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused type ignores and casts #1031

Merged
merged 12 commits into from
Aug 30, 2024
Merged

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Jul 2, 2024

Are there changes in behavior for the user?

No

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There's a few things to address to make this mergeable.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
CHANGES/1031.contrib.rst Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

webknjaz commented Jul 3, 2024

Looks like the 3.10 and 3.8 runs also need types-Pygments in their additional deps.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.60%. Comparing base (f40adb0) to head (f64186e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1031   +/-   ##
=======================================
  Coverage   62.60%   62.60%           
=======================================
  Files          38       38           
  Lines        6721     6721           
  Branches      368      368           
=======================================
  Hits         4208     4208           
  Misses       2486     2486           
  Partials       27       27           
Flag Coverage Δ
CI-GHA 62.57% <100.00%> (ø)
MyPy 25.92% <100.00%> (ø)
OS-Linux 99.26% <100.00%> (ø)
OS-Windows 99.59% <100.00%> (ø)
OS-macOS 99.03% <100.00%> (ø)
Py-3.10.11 98.94% <100.00%> (ø)
Py-3.10.14 99.15% <100.00%> (ø)
Py-3.11.9 99.15% <100.00%> (ø)
Py-3.12.5 99.15% <100.00%> (ø)
Py-3.13.0-rc.1 99.15% <100.00%> (ø)
Py-3.8.10 98.88% <100.00%> (ø)
Py-3.8.18 99.09% <100.00%> (ø)
Py-3.9.13 98.88% <100.00%> (ø)
Py-3.9.19 99.09% <100.00%> (ø)
Py-pypy7.3.11 99.40% <50.00%> (ø)
Py-pypy7.3.16 99.43% <50.00%> (ø)
VM-macos-latest 99.03% <100.00%> (ø)
VM-ubuntu-latest 99.26% <100.00%> (ø)
VM-windows-latest 99.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES/1031.contrib.rst Outdated Show resolved Hide resolved
CHANGES/1031.contrib.rst Outdated Show resolved Hide resolved
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Aug 30, 2024
@bdraco
Copy link
Member

bdraco commented Aug 30, 2024

skip label added as a workaround since the bot is currently not working as expected

@bdraco bdraco changed the title Update mypy, remove unused ignores and casts Remove unused MyPy ignores and casts Aug 30, 2024
CHANGES/1031.contrib.rst Outdated Show resolved Hide resolved
@bdraco bdraco changed the title Remove unused MyPy ignores and casts Remove unused type ignores and casts Aug 30, 2024
@bdraco
Copy link
Member

bdraco commented Aug 30, 2024

mypy already got updated so I removed that

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hauntsaninja

@bdraco bdraco enabled auto-merge (squash) August 30, 2024 23:13
@bdraco bdraco merged commit f6e2c95 into aio-libs:master Aug 30, 2024
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants