-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new method without_query_params
to drop query keys
#898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #898 +/- ##
==========================================
+ Coverage 95.02% 95.05% +0.03%
==========================================
Files 30 30
Lines 4459 4490 +31
Branches 392 396 +4
==========================================
+ Hits 4237 4268 +31
Misses 196 196
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I really do appreciate that you put in the work for a PR here, but I'd like to first see more discussion about what the API should look like. Can you please first propose this API change in the issue? (I'm not 100% convinced that the name |
Thanks. I think |
49c3b82
to
01091a6
Compare
@mjpieters @hongquan how would you feel about |
Agree with |
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
without_query_params
to drop query keys
without_query_params
to drop query keyswithout_query_params
to drop query keys
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hongquan
What do these changes do?
Add a method,
without_query_params
to drop some keys from query part.For example, dropping
"b"
in"a=1&b=2&c=3"
, we get"a=1&c=3"
.Are there changes in behavior for the user?
No.
Related issue number
closes #774
closes #1010
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.