Bk/self sizing month headers #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
commented
Aug 3, 2023
| // MARK: - VisibleMonthHeaderHeightTracker | ||
|
|
||
| /// Calculates heights for month headers by self-sizing views on the fly. Sizing views are reused to prevent unnecessary view allocations. | ||
| final class VisibleMonthHeaderHeightTracker { |
There was a problem hiding this comment.
Working on unit tests for this now
bryankeller
force-pushed
the
bk/self-sizing-month-headers
branch
from
6b6beaf
to
b4f358e
Compare
brynbodayle
reviewed
Aug 3, 2023
brynbodayle
previously approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This adds support for self-sizing month headers. I still need to add unit tests in a follow-up PR. Want to unblock some Airbnb dev first though.
Related Issue
N/A
Motivation and Context
Prior to this change, all month headers would have the same height as the first month header in the calendar. This could cause things to break if you later scrolled to a month header that needed 2 lines of text, for example.
How Has This Been Tested
Example project, horizontal and vertical calendar, SwiftUI and UIKit
Types of changes
Checklist