-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for text range selectors #2518
Merged
gpeal
merged 2 commits into
airbnb:master
from
allenchen1154:allen--add-text-range-support
Jul 24, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
lottie/src/main/java/com/airbnb/lottie/model/animatable/AnimatableTextRangeSelector.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package com.airbnb.lottie.model.animatable; | ||
|
||
import androidx.annotation.Nullable; | ||
import com.airbnb.lottie.model.content.TextRangeUnits; | ||
|
||
/** | ||
* Defines an animated range of text that should have an [AnimatableTextProperties] applied to it. | ||
*/ | ||
public class AnimatableTextRangeSelector { | ||
@Nullable public final AnimatableIntegerValue start; | ||
@Nullable public final AnimatableIntegerValue end; | ||
@Nullable public final AnimatableIntegerValue offset; | ||
public final TextRangeUnits units; | ||
|
||
public AnimatableTextRangeSelector( | ||
@Nullable AnimatableIntegerValue start, | ||
@Nullable AnimatableIntegerValue end, | ||
@Nullable AnimatableIntegerValue offset, | ||
TextRangeUnits units) { | ||
this.start = start; | ||
this.end = end; | ||
this.offset = offset; | ||
this.units = units; | ||
} | ||
} |
25 changes: 25 additions & 0 deletions
25
lottie/src/main/java/com/airbnb/lottie/model/animatable/AnimatableTextStyle.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package com.airbnb.lottie.model.animatable; | ||
|
||
import androidx.annotation.Nullable; | ||
|
||
public class AnimatableTextStyle { | ||
|
||
@Nullable public final AnimatableColorValue color; | ||
@Nullable public final AnimatableColorValue stroke; | ||
@Nullable public final AnimatableFloatValue strokeWidth; | ||
@Nullable public final AnimatableFloatValue tracking; | ||
@Nullable public final AnimatableIntegerValue opacity; | ||
|
||
public AnimatableTextStyle( | ||
@Nullable AnimatableColorValue color, | ||
@Nullable AnimatableColorValue stroke, | ||
@Nullable AnimatableFloatValue strokeWidth, | ||
@Nullable AnimatableFloatValue tracking, | ||
@Nullable AnimatableIntegerValue opacity) { | ||
this.color = color; | ||
this.stroke = stroke; | ||
this.strokeWidth = strokeWidth; | ||
this.tracking = tracking; | ||
this.opacity = opacity; | ||
} | ||
} |
6 changes: 6 additions & 0 deletions
6
lottie/src/main/java/com/airbnb/lottie/model/content/TextRangeUnits.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package com.airbnb.lottie.model.content; | ||
|
||
public enum TextRangeUnits { | ||
PERCENT, | ||
INDEX | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means we need to configure the paint on every character. I haven't looked into the performance implication or further optimization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably okay as long as we're not allocating new paint objects (which we're not)