Skip to content

Commit

Permalink
Merge branch 'fix/android-version' into 'master'
Browse files Browse the repository at this point in the history
fix(android): use api level 28

See merge request papers/airgap/airgap-vault!134
  • Loading branch information
godenzim committed Dec 6, 2019
2 parents 5f8a372 + 3238c28 commit 19a35dc
Show file tree
Hide file tree
Showing 5 changed files with 98 additions and 231 deletions.
8 changes: 4 additions & 4 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,14 @@ build_android:
- sed -i -e "s/version=\"0.0.0\"/version=\"$VERSION\"/g" config.xml
- docker build -f build/android/Dockerfile -t $IMAGE_TAG_ANDROID_CURRENT --build-arg BUILD_NR="$CI_PIPELINE_ID" --build-arg VERSION="$VERSION" .
- docker run --name $CI_PIPELINE_ID $IMAGE_TAG_ANDROID_CURRENT echo "container ran."
- docker cp $CI_PIPELINE_ID:/app/android-release-unsigned.apk android-release-unsigned-$CI_PIPELINE_ID.apk
- docker cp $CI_PIPELINE_ID:/app/android-debug.apk android-debug-$CI_PIPELINE_ID.apk
- docker cp $CI_PIPELINE_ID:/app/android-release-unsigned.apk airgap-vault-release-unsigned-$CI_PIPELINE_ID.apk
- docker cp $CI_PIPELINE_ID:/app/android-debug.apk airgap-vault-debug-$CI_PIPELINE_ID.apk
after_script:
- docker rm -f $CI_PIPELINE_ID || true
artifacts:
paths:
- android-release-unsigned-$CI_PIPELINE_ID.apk
- android-debug-$CI_PIPELINE_ID.apk
- airgap-vault-release-unsigned-$CI_PIPELINE_ID.apk
- airgap-vault-debug-$CI_PIPELINE_ID.apk

build_ios:
stage: native_build
Expand Down
2 changes: 1 addition & 1 deletion build/android/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ RUN apt-get update -y && apt-get install -y \
libcairo2-dev

# android build tools version
RUN ["/opt/tools/android-accept-licenses.sh", "android update sdk --all --no-ui --filter build-tools-26.0.2,android-27"]
RUN ["/opt/tools/android-accept-licenses.sh", "android update sdk --all --no-ui --filter build-tools-28.0.3,android-28"]

# create app directory
RUN mkdir /app
Expand Down
10 changes: 5 additions & 5 deletions config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,11 @@
<variable name="PHOTOLIBRARY_ADD_USAGE_DESCRIPTION" value="This app needs write-access to photo library" />
<variable name="PHOTOLIBRARY_USAGE_DESCRIPTION" value="This app needs read/write-access photo library access" />
</plugin>
<plugin name="cordova-android-support-gradle-release" spec="1.4.7">
<variable name="ANDROID_SUPPORT_VERSION" value="26.1.0" />
<plugin name="cordova-android-support-gradle-release" spec="3.0.1">
<variable name="ANDROID_SUPPORT_VERSION" value="28.+" />
</plugin>
<plugin name="cordova-plugin-camera-preview" spec="git+https://github.com/cordova-plugin-camera-preview/cordova-plugin-camera-preview.git">
<variable name="ANDROID_SUPPORT_LIBRARY_VERSION" value="26.1.0" />
<plugin name="cordova-plugin-camera-preview" spec="0.11.1">
<variable name="ANDROID_SUPPORT_LIBRARY_VERSION" value="28.+" />
</plugin>
<plugin name="cordova-plugin-statusbar" spec="2.4.2" />
<plugin name="ionic-plugin-deeplinks" spec="https://github.com/airgap-it/ionic-plugin-deeplinks#cordova-ios-v5.0.0-fix">
Expand Down Expand Up @@ -152,5 +152,5 @@
<plugin name="cordova-plugin-qrscanner" spec="3.0.1" />
<plugin name="cordova-plugin-airgap-security-utils" spec="0.3.6" />
<engine name="ios" spec="5.0.1" />
<engine name="android" spec="7.1.4" />
<engine name="android" spec="8.1.0" />
</widget>
Loading

0 comments on commit 19a35dc

Please sign in to comment.