-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sorting of None values in NMPVCD.do_persist(). #1321
Merged
landauermax
merged 5 commits into
ait-aecid:development
from
ernstleierzopf:245_NMPVCD_persistence
Aug 1, 2024
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
737f927
fix sorting of None values in NMPVCD.do_persist().
ernstleierzopf c844a80
readd removed lines in NMPVCD unittests.
ernstleierzopf d1bc88d
skip sorting values in NMPVCD.do_persist() if not possible.
ernstleierzopf 855252e
add comment explaining the lambda function in the NMPVCD.do_persist()…
ernstleierzopf a80e7a9
Merge branch 'ait-aecid:development' into 245_NMPVCD_persistence
ernstleierzopf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why the lambda expression is necessary here. When there is None in the list, sorting will fail.
Also, when replacing None with '-' this may be problematic if the value observed in the log lines can also be '-' (which is not unusual, e.g. in Apache Access logs). It is therefore important that None is persisted, and not some string replacement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for showing the need to comment this code.
The Lambda function is only used to allow sorting of tuples with None values. This would not be possible otherwise.
The data is later on stored normally as json (None will be null).
The data structure of known_values_set looks different. This test case is covered in the NewMatchPathValueComboDetectorTest.py lines 168-180.
Here is a simple test:
Python 3.8.10 (default, Jul 29 2024, 17:02:10)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
I don't think there is any bug in the code.