Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(mysql postgresql): high availability information #60

Merged
merged 8 commits into from
Aug 7, 2024
Merged

add(mysql postgresql): high availability information #60

merged 8 commits into from
Aug 7, 2024

Conversation

wojcik-dorota
Copy link
Contributor

@wojcik-dorota wojcik-dorota commented Feb 15, 2024 •
edited
Loading

https://aiven.atlassian.net/browse/DOC-675

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@wojcik-dorota wojcik-dorota self-assigned this Feb 15, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 15, 2024 •
edited
Loading

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a2b1ed7
Status: ✅  Deploy successful!
Preview URL: https://3452e13f.aiven-docs.pages.dev
Branch Preview URL: https://dorota-mysql-ha-docs.aiven-docs.pages.dev

View logs

@wojcik-dorota wojcik-dorota added the review/SME An SME must review the PR. label Feb 15, 2024
@wojcik-dorota wojcik-dorota marked this pull request as ready for review February 15, 2024 15:16
divdby0
divdby0 previously requested changes Feb 15, 2024
View reviewed changes
docs/products/postgresql/concepts/high-availability.md Outdated Show resolved Hide resolved
docs/products/postgresql/concepts/high-availability.md Show resolved Hide resolved
docs/products/postgresql/concepts/high-availability.md Outdated Show resolved Hide resolved
docs/products/postgresql/concepts/high-availability.md Outdated Show resolved Hide resolved
docs/products/postgresql/concepts/high-availability.md Outdated Show resolved Hide resolved
docs/products/postgresql/concepts/high-availability.md Outdated Show resolved Hide resolved
docs/products/mysql/concepts/high-availability-mysql.md Outdated Show resolved Hide resolved
docs/products/mysql/concepts/high-availability-mysql.md Outdated Show resolved Hide resolved
jfg-aiven

This comment was marked as resolved.

Sign in to view

@wojcik-dorota wojcik-dorota force-pushed the dorota-mysql-ha-docs branch 2 times, most recently from a25b236 to a1e00c4 Compare February 16, 2024 15:08
@wojcik-dorota wojcik-dorota changed the title add(mysql): high availability information add(mysql, postgres): high availability information Feb 19, 2024
@wojcik-dorota wojcik-dorota changed the title add(mysql, postgres): high availability information add(mysql, postgresql): high availability information Feb 19, 2024
@wojcik-dorota wojcik-dorota changed the title add(mysql, postgresql): high availability information add(mysql,postgresql): high availability information Feb 19, 2024
@wojcik-dorota wojcik-dorota changed the title add(mysql,postgresql): high availability information add(mysql postgresql): high availability information Feb 19, 2024
@wojcik-dorota wojcik-dorota dismissed stale reviews from jfg-aiven and divdby0 February 21, 2024 12:42

comments addressed

jfg-aiven

This comment was marked as resolved.

Sign in to view

@wojcik-dorota wojcik-dorota requested a review from a team as a code owner August 2, 2024 11:19
@wojcik-dorota wojcik-dorota force-pushed the dorota-mysql-ha-docs branch 3 times, most recently from 8371b36 to b4a9d20 Compare August 2, 2024 12:11
@wojcik-dorota wojcik-dorota requested a review from jfg-aiven August 2, 2024 12:12
@jfg-aiven jfg-aiven removed their request for review August 2, 2024 14:02
@wojcik-dorota wojcik-dorota added review/TW A TW must review the PR. Comes after review/SME. and removed review/SME An SME must review the PR. labels Aug 3, 2024
staceysalamon-aiven
staceysalamon-aiven reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@staceysalamon-aiven staceysalamon-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good info! I left some suggestions and questions. Also wondering if 2 articles are needed for this topic?

docs/products/mysql/concepts/high-availability-mysql.md Outdated Show resolved Hide resolved
docs/products/mysql/concepts/high-availability-mysql.md Outdated Show resolved Hide resolved
docs/products/mysql/concepts/high-availability-mysql.md Outdated Show resolved Hide resolved
docs/products/mysql/concepts/high-availability-mysql.md Outdated Show resolved Hide resolved
docs/products/mysql/concepts/high-availability-mysql.md Outdated Show resolved Hide resolved
docs/products/postgresql/concepts/high-availability.md Show resolved Hide resolved
docs/products/mysql/concepts/high-availability-mysql.md Outdated Show resolved Hide resolved
staceysalamon-aiven
staceysalamon-aiven approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@staceysalamon-aiven staceysalamon-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ArthurFlag
ArthurFlag previously requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@ArthurFlag ArthurFlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor harmonization comment: could you rename the file from high-availability-mysql.md to high-availability.md, that way we follow the existing pattern set by PG, and all the get-started.md, etc: no product name in the files, only for folders.

@wojcik-dorota wojcik-dorota dismissed ArthurFlag’s stale review August 7, 2024 10:20

comment addressed

@wojcik-dorota wojcik-dorota merged commit 94b2883 into main Aug 7, 2024
4 checks passed
@wojcik-dorota wojcik-dorota deleted the dorota-mysql-ha-docs branch August 7, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfg-aiven jfg-aiven jfg-aiven left review comments

@staceysalamon-aiven staceysalamon-aiven staceysalamon-aiven approved these changes

@divdby0 divdby0 divdby0 approved these changes

@alexole alexole Awaiting requested review from alexole

@ArthurFlag ArthurFlag Awaiting requested review from ArthurFlag

Assignees

@wojcik-dorota wojcik-dorota

Labels
review/TW A TW must review the PR. Comes after review/SME. service/mysql service/pg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wojcik-dorota @divdby0 @alexole @ArthurFlag @staceysalamon-aiven @jfg-aiven