Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: clarify M3DB service creation rules based on project inclusion #607

Merged
merged 2 commits into from
Dec 17, 2024
Merged

update: clarify M3DB service creation rules based on project inclusion #607

merged 2 commits into from
Dec 17, 2024

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Dec 16, 2024 •
edited
Loading

Describe your changes

  • Removed M3DB from the end of major version topic.
  • Clarified the ability to create new Aiven for M3DB services based on whether the project already includes an existing service.

DOC-1259

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@harshini-rangaswamy harshini-rangaswamy self-assigned this Dec 16, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 16, 2024 •
edited
Loading

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 681aa9e
Status: ✅  Deploy successful!
Preview URL: https://95e801c7.aiven-docs.pages.dev
Branch Preview URL: https://harshini-m3db-udpates.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review December 16, 2024 13:04
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner December 16, 2024 13:04
@harshini-rangaswamy harshini-rangaswamy added the review/TW A TW must review the PR. Comes after review/SME. label Dec 17, 2024
staceysalamon-aiven
staceysalamon-aiven approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@staceysalamon-aiven staceysalamon-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshini-rangaswamy harshini-rangaswamy merged commit 8c9b5c0 into main Dec 17, 2024
5 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the harshini-m3db-udpates branch December 17, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staceysalamon-aiven staceysalamon-aiven staceysalamon-aiven approved these changes

@hoang-vo hoang-vo hoang-vo approved these changes

Assignees

@harshini-rangaswamy harshini-rangaswamy

Labels
platform review/TW A TW must review the PR. Comes after review/SME.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshini-rangaswamy @hoang-vo @staceysalamon-aiven