Apply Aiven-specific changes on top of upstream 4.1.3 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatlink
commented
Oct 27, 2023
meatlink
commented
- changes related to .spec file were omitted, we do not need them anymore
- RF uptuning functionality were omitted, because now we have guardrails framework for that
The data will be provided by Astacus, streaming from other nodes is not necessary.
It's more convenient to set it there in Astacus. Option semantics is preserved, the value specified in Java properties has priority.
We decorate standard PasswordAuthenticator with a few platform specific features, that don't change the externally observable behavior - so it's absolutely compatible with PasswordAuthenticator. A few tools and client libraries do not support custom authenticators. For example: ZDM Proxy. They fail whenever they see anything but PasswordAuthenticator nevertheless they are in fact completely compatible. So we want to stop advertising our custom authenticator and pretend that it's a standard PasswordAuthenticator.
|
the 4.0.11 branch seems to have this commit 7372136 do we not need it here ? |
sjamgade
previously requested changes
Nov 20, 2023
|
I'm trying the "assignee" workflow and arbitrarily assigned @sjamgade to this :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.