This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HowTo topics for Kafka tiered storage #2162
HowTo topics for Kafka tiered storage #2162
Changes from 3 commits
ea3b43d
8da73cb
ea53106
c756267
ae6bc71
5b03ddb
275484c
53e274b
54e4de9
5c46b5c
8539c2d
c04a982
d13a248
ebd2e7a
b6ef123
34a6216
4fba9fd
2bf4d35
72b956d
c270686
83b0123
69f2489
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the default was not to use it, interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried setting Remote storage enable to Default, and it does nothing. But this is going to be an obvious question from the user. Why have Default in the drop-down when it does nothing? Is there a way to remove it?
For now, I will remove this note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i think so. Default in the topic configs means "not set", meaning it's as if it was never touched by user. (Maybe it should be "Not set" instead of "Default" 🤔) In this case, as you need to explicitly enable remote storage per topic, the default is that it's not enabled. Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that the price can be seen in the overview section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiered storage* (i think?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's the name of a section? I can't find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is related to the concept topics in the PR - #2142. I'm unable to create direct links at the moment, as they would lead to broken links and prevent me from merging the content into the main branch.
Check failure on line 17 in docs/products/kafka/howto/kafka-tiered-storage-get-started.rst
GitHub Actions / vale
[vale] docs/products/kafka/howto/kafka-tiered-storage-get-started.rst#L17
Raw output
Check failure on line 17 in docs/products/kafka/howto/kafka-tiered-storage-get-started.rst
GitHub Actions / vale
[vale] docs/products/kafka/howto/kafka-tiered-storage-get-started.rst#L17
Raw output
Check failure on line 27 in docs/products/kafka/howto/kafka-tiered-storage-get-started.rst
GitHub Actions / vale
[vale] docs/products/kafka/howto/kafka-tiered-storage-get-started.rst#L27
Raw output
Check failure on line 34 in docs/products/kafka/howto/kafka-tiered-storage-get-started.rst
GitHub Actions / vale
[vale] docs/products/kafka/howto/kafka-tiered-storage-get-started.rst#L34
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if these should mention the actual setting name? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the name the user would see on the "Tiered storage overview" page. Do you mean add this -
kafka.log_local_retention_bytes
andkafka.log_local_retention_ms
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, those are the actual settings names. I'm just thinking that if for example you use the CLI, you would use the real setting names so it could be reassuring that we are in fact talking about the exact same service level settings.
I think we should just use the real setting name in console as well to avoid confusion.