Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

clickhouse: add supported table functions and file formats #2170

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

wojcik-dorota
Copy link
Contributor

@wojcik-dorota wojcik-dorota commented Oct 5, 2023

@wojcik-dorota wojcik-dorota changed the title draft clickhouse: add supported table functions and file formats Oct 5, 2023
@wojcik-dorota wojcik-dorota self-assigned this Oct 5, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7421db0
Status: ✅  Deploy successful!
Preview URL: https://2252496e.devportal.pages.dev
Branch Preview URL: https://dorota-clickhouse-add-ref-do.devportal.pages.dev

View logs

Copy link

@ArthurAnsquer ArthurAnsquer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine! Suggested title change otherwise all good! @joelynch could you double check and merge if it looks fine to you? I don't have the permissions to do so yet :D

docs/products/clickhouse/reference/table-functions.rst Outdated Show resolved Hide resolved
docs/products/clickhouse/reference/table-functions.rst Outdated Show resolved Hide resolved
joelynch
joelynch previously approved these changes Oct 6, 2023
Copy link

@joelynch joelynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a suggestion

docs/products/clickhouse/reference/table-functions.rst Outdated Show resolved Hide resolved
docs/products/clickhouse/reference/table-functions.rst Outdated Show resolved Hide resolved
@joelynch
Copy link

joelynch commented Oct 9, 2023

@wojcik-dorota do you want me to merge this? Is the author allowed to merge for this repo?

@wojcik-dorota
Copy link
Contributor Author

@wojcik-dorota do you want me to merge this? Is the author allowed to merge for this repo?

@joelynch the author can merge so I'll do that. Thanks for all your support :-)

@wojcik-dorota wojcik-dorota merged commit abad34f into main Oct 9, 2023
5 checks passed
@wojcik-dorota wojcik-dorota deleted the dorota-clickhouse-add-ref-docs branch October 9, 2023 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants