This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
staceysalamon-aiven
previously requested changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update on the Terraform page looks good! Thanks!
wojcik-dorota
suggested changes
Oct 29, 2023
runwuf
force-pushed
the
fwu-fix-links
branch
2 times, most recently
from
November 1, 2023 01:40
cdab35b
to
e8c5674
Compare
wojcik-dorota
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The ClickHouse part LGTM.
Plz acquire approval from @harshini-rangaswamy for the Kafka part before merging.
docs/products/kafka/kafka-mirrormaker/reference/known-issues.rst
Outdated
Show resolved
Hide resolved
harshini-rangaswamy
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@runwuf, a minor change to the text. The rest looks good. Thanks!
runwuf
dismissed
staceysalamon-aiven’s stale review
November 3, 2023 00:55
updated suggested changes
harshini-rangaswamy
approved these changes
Nov 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated various broken links