This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
wojcik-dorota
suggested changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this update :-) A few editorial comments..
runwuf
force-pushed
the
fwu-vpc-peering-updates
branch
from
November 15, 2023 22:17
32082ba
to
2050f1c
Compare
sorry for the delay @wojcik-dorota it's ready to be re-reviewed again, thanks! |
wojcik-dorota
suggested changes
Nov 16, 2023
Comment on lines
30
to
32
1. Enter a name for the peering connection. | ||
2. Under **Peered VPC network**, select **In another project**. | ||
3. Enter the Aiven project ID and the VPC network name identified in step 7 in Aiven Console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indent here is too deep. Please you the 3-chars indent coz otherwise it renders incorrectly on the docs website.
runwuf
force-pushed
the
fwu-vpc-peering-updates
branch
from
November 17, 2023 01:35
2050f1c
to
5cd594a
Compare
wojcik-dorota
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Many thanks 🙏🏻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP Console has changed, updating the instruction to reflect with the latest UI.