Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Updated GCP VPC peering how-to #2217

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Updated GCP VPC peering how-to #2217

merged 2 commits into from
Nov 17, 2023

Conversation

runwuf
Copy link
Contributor

@runwuf runwuf commented Nov 3, 2023

GCP Console has changed, updating the instruction to reflect with the latest UI.

@runwuf runwuf requested a review from wojcik-dorota November 3, 2023 00:40
Copy link

cloudflare-workers-and-pages bot commented Nov 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5cd594a
Status: ✅  Deploy successful!
Preview URL: https://6f8f3e49.devportal.pages.dev
Branch Preview URL: https://fwu-vpc-peering-updates.devportal.pages.dev

View logs

Copy link
Contributor

@wojcik-dorota wojcik-dorota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this update :-) A few editorial comments..

docs/platform/howto/vpc-peering-gcp.rst Outdated Show resolved Hide resolved
docs/platform/howto/vpc-peering-gcp.rst Outdated Show resolved Hide resolved
docs/platform/howto/vpc-peering-gcp.rst Outdated Show resolved Hide resolved
docs/platform/howto/vpc-peering-gcp.rst Outdated Show resolved Hide resolved
docs/platform/howto/vpc-peering-gcp.rst Outdated Show resolved Hide resolved
docs/platform/howto/vpc-peering-gcp.rst Outdated Show resolved Hide resolved
@runwuf runwuf force-pushed the fwu-vpc-peering-updates branch from 32082ba to 2050f1c Compare November 15, 2023 22:17
@runwuf runwuf requested a review from wojcik-dorota November 15, 2023 22:31
@runwuf
Copy link
Contributor Author

runwuf commented Nov 15, 2023

sorry for the delay @wojcik-dorota it's ready to be re-reviewed again, thanks!

Comment on lines 30 to 32
1. Enter a name for the peering connection.
2. Under **Peered VPC network**, select **In another project**.
3. Enter the Aiven project ID and the VPC network name identified in step 7 in Aiven Console.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indent here is too deep. Please you the 3-chars indent coz otherwise it renders incorrectly on the docs website.

@runwuf runwuf force-pushed the fwu-vpc-peering-updates branch from 2050f1c to 5cd594a Compare November 17, 2023 01:35
Copy link
Contributor

@wojcik-dorota wojcik-dorota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks 🙏🏻

@wojcik-dorota wojcik-dorota merged commit eacbac0 into main Nov 17, 2023
5 checks passed
@wojcik-dorota wojcik-dorota deleted the fwu-vpc-peering-updates branch November 17, 2023 05:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants