Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove allow list, generate everything #127

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Mar 21, 2024

We won't know there is a new type of service integration/endpoint available because it will be filtered out by the allow list. Better explicitly disable them on terraform side.

@byashimov byashimov requested a review from a team March 21, 2024 11:41
@byashimov byashimov force-pushed the byashimov-remove-allow-list branch 2 times, most recently from d08be80 to 5f1e8a3 Compare March 21, 2024 11:42
@byashimov byashimov force-pushed the byashimov-remove-allow-list branch from 5f1e8a3 to 5ad6943 Compare March 21, 2024 11:54
@Serpentiel Serpentiel self-assigned this Mar 21, 2024
@Serpentiel Serpentiel added the enhancement New feature or request label Mar 21, 2024
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel enabled auto-merge (squash) March 21, 2024 13:34
@Serpentiel Serpentiel merged commit bafb75b into main Mar 21, 2024
7 checks passed
@Serpentiel Serpentiel deleted the byashimov-remove-allow-list branch March 21, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants