Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return response body on error status code #186

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: return response body on error status code #186

merged 1 commit into from
Nov 20, 2024

Conversation

byashimov
Copy link
Contributor

Uses retryablehttp.PassthroughErrorHandler to return response body as an error. By default retryablehttp returns attempts information instead.

@byashimov
fix: return response body on error status code
f4be6fa 
Uses retryablehttp.PassthroughErrorHandler to return response body as an error.
By default retryablehttp returns attempts information instead.
@byashimov byashimov requested a review from a team as a code owner November 20, 2024 14:40
@byashimov
Copy link
Contributor Author

Starts here https://github.com/hashicorp/go-retryablehttp/blob/9dfd949154e507c91ee569367ffa461991b80950/client.go#L807

@byashimov byashimov marked this pull request as draft November 20, 2024 14:43
@byashimov byashimov marked this pull request as ready for review November 20, 2024 15:21
@byashimov byashimov merged commit 48d19a9 into main Nov 20, 2024
6 checks passed
@byashimov byashimov deleted the byashimov-fix-error-status-message-handling branch November 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rriski rriski rriski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @rriski