Skip to content

Commit

Permalink
Closes Bears-R-Us#3695: Fix Parquet Fixed-Length Code Path for Incorr…
Browse files Browse the repository at this point in the history
…ect File Size Assumption (Bears-R-Us#3696)

* Fix Parquet Fixed-Length Code Path for Incorrect File Size Assumption
The current implementation of the fixed-length code path for reading Parquet files incorrectly assumes that all files within a dataset have the same number of strings. This can lead to incorrect results or unexpected behavior when dealing with datasets where files have varying numbers of strings.

* Remove accidental +
  • Loading branch information
bmcdonald3 committed Aug 28, 2024
1 parent 733c79d commit 108f086
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/ParquetMsg.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,8 @@ module ParquetMsg {
byteSizes = calcStrSizesAndOffset(entrySeg.a, filenames, sizes, dsetname);
} else {
entrySeg.a = fixedLen;
byteSizes = fixedLen*len;
for i in sizes.domain do
byteSizes[i] = fixedLen*sizes[i];
}
entrySeg.a = (+ scan entrySeg.a) - entrySeg.a;

Expand Down

0 comments on commit 108f086

Please sign in to comment.