Add orml-vesting benchmarks #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
force-pushed
the
cl/orml-benchmarks
branch
from
f5dfd9b to
4e8aba5
Compare
clangenb
commented
Mar 17, 2024
| use frame_system::RawOrigin; | ||
| use sp_std::prelude::*; | ||
|
|
||
| use orml_benchmarking::runtime_benchmarks; |
There was a problem hiding this comment.
Todo: use the frame-benchmarking::benchmarks macro here and rewrite the benchmarks.
clangenb
commented
Mar 17, 2024
Comment on lines
-491
to
+493
| pub const MinVestedTransfer: Balance = 100 * MICRO_BAJUN; | ||
| pub const MinVestedTransfer: Balance = MILLI_BAJUN; |
There was a problem hiding this comment.
This was below the ED.
This was referenced Mar 26, 2024
|
Superseded by #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add orml-vesting benchmark in similar fashion to how they do it in acala: https://github.com/AcalaNetwork/Acala/blob/b5b5a7499702067421745edd93c686abf6476f19/runtime/mandala/src/benchmarking/mod.rs
Todo: Currently, the orml-benchmarks and the regular runtime-benchmarks can't be built simultaneously because they are different, and we get some type errors if we want to compile them both. However, it should be fairly straightforward to change the paradigm used in the orml-vesting benchmarking to be the same as the polkadot-sdk pallets, and then we can unify the benchmarking. Furhtermore, if we do it like that, we probably want to move the orml-vesting-benchmarks into the ajuna-pallets repository, such that they can be re-used in the ajuna-parachain.
To preserve a clean git history on develop, I suggest merging the other PRs first: