Adjustments for v170 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
clangenb
reviewed
Feb 16, 2024
There was a problem hiding this comment.
The changes look good to me, thanks!
I would still like to change the MessageQueue pallet index to 34, this is also how a parity did it for their chains https://github.com/polkadot-fellows/runtimes/blob/932fc1555e9892c66f8394ee55c63faf4436d7a4/system-parachains/collectives/collectives-polkadot/src/lib.rs#L662.
As we don't have any xcm activity, I would suggest we remove the dmpq-pallet (contrary to parity). Regardless, can you leave the definition of the dmpq-pallet in the construct-runtime macro for future reference of the previously occupied slot?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issues highlighted in #1
Type of changes
build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)ci: Changes to CI configurationdocs: Changes to documentation onlyfeat: Changes to add a new featurefix: Changes to fix a bugrefactor: Changes that do not alter functionalitystyle: Changes to format the codetest: Changes to add missing tests or correct existing testsChecklist
cargo fmt --allcargo clippy --all-features --all-targetscargo test --workspace --all-features --all-targets