Add awesome avatars multi-block-migration with pallet-migrations #21
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,6 +49,7 @@ use frame_support::{ | |
| construct_runtime, | ||
| dispatch::DispatchClass, | ||
| genesis_builder_helper::{build_config, create_default_config}, | ||
| migrations::{FailedMigrationHandler, FailedMigrationHandling, MigrationStatusHandler}, | ||
| pallet_prelude::ConstU32, | ||
| parameter_types, | ||
| traits::{ | ||
|
|
@@ -157,13 +158,8 @@ pub type Executive = frame_executive::Executive< | |
| frame_system::ChainContext<Runtime>, | ||
| Runtime, | ||
| AllPalletsWithSystem, | ||
| >; | ||
|
|
||
| /// Handles converting a weight scalar to a fee value, based on the scale and granularity of the | ||
| /// node's balance type. | ||
| /// | ||
|
|
@@ -379,13 +375,75 @@ impl frame_system::Config for Runtime { | |
| /// The Block provider type | ||
| type Block = Block; | ||
| type RuntimeTask = RuntimeTask; | ||
| type SingleBlockMigrations = SingleBlockMigrations; | ||
| type MultiBlockMigrator = pallet_migrations::Pallet<Runtime>; | ||
| type PreInherents = (); | ||
| type PostInherents = (); | ||
| type PostTransactions = (); | ||
| } | ||
|
|
||
| type SingleBlockMigrations = (pallet_ajuna_awesome_avatars::migration::v6::MigrateToV6<Runtime>,); | ||
|
|
||
| #[cfg(not(feature = "runtime-benchmarks"))] | ||
| use mbm::MultiBlockMigrations; | ||
|
|
||
| #[cfg(not(feature = "runtime-benchmarks"))] | ||
| mod mbm { | ||
| use crate::Runtime; | ||
| use pallet_ajuna_awesome_avatars::migration::v6::mbm::{ | ||
| LazyMigrationAvatarV5ToV6, LazyMigrationPlayerSeasonConfigsV5ToV6, | ||
| LazyMigrationSeasonStatsV5ToV6, LazyTradeStatsMapCleanup, | ||
| }; | ||
|
|
||
| use crate::weights::pallet_ajuna_awesome_avatars_mbm::WeightInfo as AaaMbmWeight; | ||
|
|
||
| pub type MultiBlockMigrations = ( | ||
| LazyMigrationPlayerSeasonConfigsV5ToV6<Runtime, AaaMbmWeight<Runtime>>, | ||
| LazyMigrationSeasonStatsV5ToV6<Runtime, AaaMbmWeight<Runtime>>, | ||
| LazyMigrationAvatarV5ToV6<Runtime, AaaMbmWeight<Runtime>>, | ||
| LazyTradeStatsMapCleanup<Runtime, AaaMbmWeight<Runtime>>, | ||
| ); | ||
| } | ||
|
|
||
| parameter_types! { | ||
| pub MbmServiceWeight: Weight = Perbill::from_percent(80) * RuntimeBlockWeights::get().max_block; | ||
| } | ||
|
Comment on lines
+408
to
+410
There was a problem hiding this comment. Todo: Double check if we should be more conservative here. Substrate doesn't have meaningful example value in their test runtime, but I think 80% should be ok. There was a problem hiding this comment. Parity has now introduced the same weight as mine. 80% percent allowed usage of a max value seems to be the rule of thumb for any weight-limited operation: https://github.com/paritytech/polkadot-sdk/pull/4251/files |
||
|
|
||
| impl pallet_migrations::Config for Runtime { | ||
| type RuntimeEvent = RuntimeEvent; | ||
| type CursorMaxLen = ConstU32<65_536>; | ||
| type IdentifierMaxLen = ConstU32<256>; | ||
| type MigrationStatusHandler = LoggerMigrationStatusHandler; | ||
| type FailedMigrationHandler = frame_support::migrations::FreezeChainOnFailedMigration; | ||
| type MaxServiceWeight = MbmServiceWeight; | ||
| type WeightInfo = weights::pallet_migrations::WeightInfo<Runtime>; | ||
| #[cfg(feature = "runtime-benchmarks")] | ||
| type Migrations = pallet_migrations::mock_helpers::MockedMigrations; | ||
| #[cfg(not(feature = "runtime-benchmarks"))] | ||
| type Migrations = MultiBlockMigrations; | ||
| } | ||
|
|
||
| /// Records all started and completed upgrades in `UpgradesStarted` and `UpgradesCompleted`. | ||
| pub struct LoggerMigrationStatusHandler; | ||
| impl MigrationStatusHandler for LoggerMigrationStatusHandler { | ||
| fn started() { | ||
| log::info!("MigrationStatusHandler started"); | ||
| } | ||
|
|
||
| fn completed() { | ||
| log::info!("MigrationStatusHandler completed"); | ||
| } | ||
| } | ||
|
|
||
| /// Records all failed upgrades in `UpgradesFailed`. | ||
| pub struct MockedFailedMigrationHandler; | ||
| impl FailedMigrationHandler for MockedFailedMigrationHandler { | ||
| fn failed(migration: Option<u32>) -> FailedMigrationHandling { | ||
| log::error!("FailedMigrationHandler failed at: {migration:?}"); | ||
| FailedMigrationHandling::ForceUnstuck | ||
|
There was a problem hiding this comment. This will make the chain resume normal operation and allow extrinsics again, but it will not continue the migration. Here, I suggest we assume that it works now after testing with the production data. Otherwise we could start integrating the pallet-safe-mode, which is not audited yet though. There was a problem hiding this comment. I suggest keeping it at There was a problem hiding this comment. To me it looks like you are actually using the freeze option @clangenb : There was a problem hiding this comment. ooops, good catch. Fuck up on my end. Thanks for pointing this out! |
||
| } | ||
| } | ||
|
|
||
| impl pallet_sudo::Config for Runtime { | ||
| type RuntimeEvent = RuntimeEvent; | ||
| type RuntimeCall = RuntimeCall; | ||
|
|
@@ -893,6 +951,7 @@ construct_runtime!( | |
| Proxy: pallet_proxy = 7, | ||
| Scheduler: pallet_scheduler = 8, | ||
| Preimage: pallet_preimage = 9, | ||
| Migrations: pallet_migrations = 10, | ||
|
|
||
| // Monetary stuff. | ||
| Balances: pallet_balances = 15, | ||
|
|
@@ -961,6 +1020,7 @@ mod benches { | |
| [pallet_membership, CouncilMembership] | ||
| // [pallet_membership, TechnicalCommitteeMembership] // writes to the same file | ||
| [pallet_message_queue, MessageQueue] | ||
| [pallet_migrations, Migrations] | ||
| [pallet_multisig, Multisig] | ||
| [pallet_preimage, Preimage] | ||
| [pallet_proxy, Proxy] | ||
|
|
@@ -971,12 +1031,13 @@ mod benches { | |
| // [pallet_treasury, Treasury] // treasury config is broken, needs fixes | ||
| [pallet_utility, Utility] | ||
| [pallet_ajuna_awesome_avatars, AwesomeAvatarsBench::<Runtime>] | ||
| // Note: We have to update the path to the `WeightInfo` definition after | ||
| // running the benchmarks: `pallet_ajuna_awesome_avatars::migration::v6::WeightInfo` | ||
| [pallet_ajuna_awesome_avatars_mbm, AwesomeAvatars] | ||
| [pallet_nfts, Nft] | ||
| ); | ||
| // Use this section if you want to benchmark individual pallets | ||
| // define_benchmarks!([pallet_ajuna_awesome_avatars_mbm, AwesomeAvatars]); | ||
| } | ||
|
|
||
| #[cfg(feature = "runtime-benchmarks")] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is obsolete now, the single block migrations are also configured in frame-system now.