-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Governance Configuration and Chopsticks setup #6
Conversation
…ces for both collective instances
…to non-transfer proxy type
@@ -940,21 +918,23 @@ extern crate frame_benchmarking; | |||
#[cfg(feature = "runtime-benchmarks")] | |||
mod benches { | |||
define_benchmarks!( | |||
[cumulus_pallet_xcmp_queue, XcmpQueue] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorted the substrate pallet entries here and added the membership benchmarks.
@@ -429,7 +436,7 @@ impl pallet_balances::Config for Runtime { | |||
type ReserveIdentifier = [u8; 8]; | |||
type FreezeIdentifier = (); | |||
type MaxFreezes = (); | |||
type RuntimeHoldReason = (); | |||
type RuntimeHoldReason = RuntimeHoldReason; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke submitting preimages .
type Consideration = HoldConsideration< | ||
AccountId, | ||
Balances, | ||
PreimageHoldReason, | ||
LinearStoragePrice<PreimageBaseDeposit, PreimageByteDeposit, Balance>, | ||
>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same config as kusama
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good!
Let's move this in place then, for a runtime upgrade. |
This PR adds the governance config, namely it adds the technical committee including its membership pallet instance, and adds the democracy pallet. I decided to add the membership pallet after all because during the polkadot update there was a new
EnsureSignedBy
origin check introduced in substrate. This struct made my manual implementation to ensure that the submit proposal origin is a council member obsolete. However, it works only with the membership pallet.Note: This PR also fixes the pallet-preimage configuration. Submitting a preimage was broken before.
Chopsticks tests
Fork of the current network and do:
councilMembership.resetMembers(Alice, Bob, Charlie)
technicalCommitteeMembership.resetMembers(Alice, Bob, Charlie)
councilMembership.setPrime(Alice)
balances.forceSetBalance(Charlie, 1000000000000)
council.proposeExternal(preimageHash, preimageLength)
api.rpc('dev_newBlock', { count: 10 })
api.rpc('dev_newBlock', { count: 5})
The governance stuff is pretty complex, and more things can be tested, but the above tests are the most crucial things to ensure that we don't lock ourselves out of the system.