Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run single block migrations in executive to make it compatible with the try-runtime-cli #60

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Run single block migrations in executive to make it compatible with the try-runtime-cli #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7320a18
[runtime] execute single block migrations in the `Executive` again
clangenb Jun 4, 2024
4ec23af
[runtime] fix: configure the Multiblock migrator without configuring …
clangenb Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion runtime/bajun/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ pub type Executive = frame_executive::Executive<
frame_system::ChainContext<Runtime>,
Runtime,
AllPalletsWithSystem,
SingleBlockMigrations,
>;

/// Handles converting a weight scalar to a fee value, based on the scale and granularity of the
Expand Down Expand Up @@ -374,7 +375,12 @@ impl frame_system::Config for Runtime {
/// The Block provider type
type Block = Block;
type RuntimeTask = RuntimeTask;
type SingleBlockMigrations = SingleBlockMigrations;
// Note: Single block migrations are currently run in the classical way in the `Executive`
// because try-runtime doesn't support the pallet-migrations yet.
//
// Once it is supported, we want to switch to the pallet-migrations, but we **must** ensure
// that we remove the migrations from the `Executive` to prevent running the migrations twice.
type SingleBlockMigrations = ();
type MultiBlockMigrator = pallet_migrations::Pallet<Runtime>;
type PreInherents = ();
type PostInherents = ();
Expand Down
Loading