[AJUN-495] Runtime Upgrade for Async Backing #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Nice, except for one comment I think this looks good.
I reviewed that:
- The changes correspond to the guide https://wiki.polkadot.network/docs/maintain-guides-async-backing#phase-3---activate-async-backing
- Double checked that the service aligns with the parachain
polkadot-sdk\cumulus\polkadot-parachain\src\service.rs - Checked that the runtime matches the
polkadot-sdk\templates\parachain\runtime\srcalthough the runtime is so minimal that not everything is covered.
runtime/bajun/src/lib.rs
Outdated
| type MinimumPeriod = ConstU64<0>; | ||
| type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>; |
There was a problem hiding this comment.
This change is wrong IMO, it should stay at 0 if I read this correctly: https://wiki.polkadot.network/docs/maintain-guides-async-backing#phase-3---activate-async-backing
(But maybe it was wrong that it was 0 before XD)
There was a problem hiding this comment.
True, you are right about that!
clangenb
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates runtime to enabled 6s blocks through async-backing
Type of changes
build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)ci: Changes to CI configurationdocs: Changes to documentation onlyfeat: Changes to add a new featurefix: Changes to fix a bugrefactor: Changes that do not alter functionalitystyle: Changes to format the codetest: Changes to add missing tests or correct existing testsChecklist
cargo fmt --allcargo clippy --all-features --all-targetscargo test --workspace --all-features --all-targets