Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1beta4 market protobuf files #62

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Add v1beta4 market protobuf files #62

merged 2 commits into from
Nov 17, 2023

Conversation

Redm4x
Copy link
Contributor

@Redm4x Redm4x commented Nov 7, 2023

  • Renerated the protobuf files to add v1beta4 market types
  • Updated the stargate messages to use /akash.market.v1beta4.MsgCreateLease

Still need to update the version in test_leases.ts, but that would break the tests since the rpc node is not upgraded. Maybe this should be changed after the mainnet upgrade

@Redm4x Redm4x marked this pull request as ready for review November 16, 2023 22:23
@@ -24,5 +24,5 @@ export enum messages {
MsgCloseGroup = "/akash.deployment.v1beta3.MsgCloseGroup",
MsgPauseGroup = "/akash.deployment.v1beta3.MsgPauseGroup",
MsgStartGroup = "/akash.deployment.v1beta3.MsgStartGroup",
MsgCreateLease = "/akash.market.v1beta3.MsgCreateLease",
MsgCreateLease = "/akash.market.v1beta4.MsgCreateLease",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure should probably be depricated, but I'm fine with the change.

@Redm4x Redm4x merged commit cdc1ace into main Nov 17, 2023
1 check passed
@Redm4x Redm4x deleted the add-v1beta4-market-proto branch November 17, 2023 02:23
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
* Regenerate protobuf files

* Update version in stargate messages 0.4.19
PoolPirate pushed a commit to Farsight-CDA/akashjs that referenced this pull request Dec 6, 2023
* Regenerate protobuf files

* Update version in stargate messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants