-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(certificates): implement certificate manager #89
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 70.92% 71.57% +0.64%
==========================================
Files 21 23 +2
Lines 743 795 +52
Branches 184 189 +5
==========================================
+ Hits 527 569 +42
- Misses 215 225 +10
Partials 1 1 ☔ View full report in Codecov by Sentry. |
serial: { int: Math.floor(new Date().getTime() * 1000) }, | ||
issuer: { str: "/CN=" + address }, | ||
notbefore: notBeforeStr, | ||
notafter: notAfterStr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add right now, but it would be nice to be able to specify the expiry date when creating a cert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
a2f36d7
to
866e41a
Compare
After the implementation from cloudmos refs #76
@Redm4x yes, that was the idea |
🎉 This PR is included in version 0.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
After the implementation from cloudmos
refs #76