Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(certificates): implement certificate manager #89

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

ygrishajev
Copy link
Contributor

After the implementation from cloudmos

refs #76

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 71.57%. Comparing base (4657dc5) to head (e6a84eb).
Report is 1 commits behind head on main.

Files Patch % Lines
src/certificates/index.ts 0.00% 15 Missing ⚠️
src/certificates/certificate-manager/index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   70.92%   71.57%   +0.64%     
==========================================
  Files          21       23       +2     
  Lines         743      795      +52     
  Branches      184      189       +5     
==========================================
+ Hits          527      569      +42     
- Misses        215      225      +10     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ygrishajev ygrishajev marked this pull request as ready for review May 13, 2024 14:27
src/certificates/certificate-rpc/CertificateRpc.ts Outdated Show resolved Hide resolved
serial: { int: Math.floor(new Date().getTime() * 1000) },
issuer: { str: "/CN=" + address },
notbefore: notBeforeStr,
notafter: notAfterStr,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add right now, but it would be nice to be able to specify the expiry date when creating a cert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Redm4x
Copy link
Contributor

Redm4x commented May 13, 2024

generate509.ts and the pkijs package are kept to keep backward compatibility?

@ygrishajev ygrishajev force-pushed the fix/cert branch 2 times, most recently from a2f36d7 to 866e41a Compare May 13, 2024 15:16
After the implementation from cloudmos

refs #76
@ygrishajev
Copy link
Contributor Author

ygrishajev commented May 13, 2024

generate509.ts and the pkijs package are kept to keep backward compatibility?

@Redm4x yes, that was the idea

src/certificates/index.ts Outdated Show resolved Hide resolved
src/certificates/index.ts Outdated Show resolved Hide resolved
@ygrishajev ygrishajev merged commit 21699d8 into main May 13, 2024
3 checks passed
@ygrishajev ygrishajev deleted the fix/cert branch May 13, 2024 19:19
Copy link

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants