Support new approach for storing gateway cache encryption key in k8s secrets #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-akeyless
approved these changes
Oct 29, 2024
omriezra
reviewed
Oct 29, 2024
omriezra
previously approved these changes
Oct 29, 2024
omriezra
reviewed
Oct 31, 2024
|
|
||
| {{/* RBAC rule to access the secret if storeEncryptionKeyToK8sSecrets is true and clusterCacheEncryptionKeyExist is not empty */}} | ||
| {{- if and (eq $.Values.cachingConf.clusterCache.storeEncryptionKeyToK8sSecrets true) (not (eq (include "akeyless-api-gw.clusterCacheEncryptionKeyExist" $) "")) }} |
There was a problem hiding this comment.
this condition needs to be update to support all the cases:
- if secret exist
- if secret not exist
should basically be create if cache enabled
@rani-sharim
OriBenHur-akeyless
approved these changes
Oct 31, 2024
OriBenHur-akeyless
approved these changes
Nov 3, 2024
OriBenHur-akeyless
approved these changes
Nov 6, 2024
…ey in k8s secrets.
…ey in k8s secrets.
rani-sharim
force-pushed
the
store_gw_cache_enc_key
branch
from
eccccba
to
0be4bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task: ASM-12592 - Redis Enc Key Management In SaaS Gator
Changes:
New field:
storeEncryptionKeyToK8sSecrets- When set totrue, the cache encryption key is stored in K8s secrets, supporting Auto Scaling scenarios without network connectivity.Enhancements to field
encryptionKeyExistingSecret:When chart creating the Service Account, we also take care to create a Role and Role Binding to the created Service Account with appropriate K8s secret permissions (get, create, update) on this specific secret name, allowing the gateway to manage the cache encryption key securely in Kubernetes.