Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "Code review" starting copy #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding "Code review" starting copy #44

wants to merge 1 commit into from

Conversation

edmullen
Copy link
Contributor

This language is copied from the EIS-R (DPA) repo. It serves as a good starting point that OCS can use to define the way they intend to conduct code reviews during the Dashboard procurement.

OCS can use this as their starting point and use as much as is useful and change as much as necessary. @cnelsonakgov could share insights on how it has worked for the EIS-R (DPA) project.

This language is copied from the EIS-R (DPA) repo. It serves as a good starting point that OCS can use to define the way they intend to conduct code reviews during the Dashboard procurement. 

OCS can use this as their starting point and use as much as is useful and change as much as necessary. @cnelsonakgov could share insights on how it has worked for the EIS-R (DPA) project.
@edmullen edmullen requested a review from waldoj August 29, 2018 15:30
@edmullen
Copy link
Contributor Author

@waldoj I'd like you to take a look at this. I'm copying the DPA code review language to the OCS repo. I want to be sure this all remains valid. Can you please review and let me know what state it's in.

  • If it all applies, great.
  • If small changes are needed, please make them.
  • If extensive changes are needed, let me know.

@edmullen edmullen changed the title Adding "Code review" copy Adding "Code review" starting copy Aug 29, 2018
@cnelsonakgov
Copy link
Member

This process worked very well for the EIS-R (DPA) project:

  • We used the checklist and pulled this document up before every sprint code review for reference.
  • The process accommodates the VSTS workflow nicely.
  • It's a living document -- as our code reviews evolved, we modified it to reflect that
  • Enabled us to be more confident that we could build and manage the code at the end of the project

@waldoj
Copy link
Contributor

waldoj commented Aug 29, 2018

Yeah, what Curtis said. :) I think this is all likely to apply, but it really is best to regard it as a living document. We freely edited it as we found that reality didn't match our intentions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants