Feature rabbitmq as message broker #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhundMurad
requested changes
Nov 13, 2023
|
|
||
|
|
||
| class RabbitMQMessageBroker: | ||
| def __init__(self, client, *, routing_key: str | None = None, exchange: str | None = None) -> None: |
There was a problem hiding this comment.
Please define the type of client argument
|
|
||
| async def send_message(self, message: Message) -> None: | ||
| async with self._connection as connection: | ||
|
|
There was a problem hiding this comment.
Try to build a message here and the pass it to the basic_publish or publish
| @@ -12,3 +12,17 @@ def redis_client() -> redis.Redis: | |||
| @pytest.fixture() | |||
| def redis_message_broker(redis_client: redis.Redis) -> RedisMessageBroker: | |||
| return RedisMessageBroker(client=redis_client, channel_prefix="test_diator_channel") | |||
|
|
|||
| @pytest.fixture() | |||
| async def rabbitmq_client() -> aio_pika.Connection: | |||
There was a problem hiding this comment.
It would be better to use:
https://testcontainers-python.readthedocs.io/en/latest/rabbitmq/README.html - for RabbitMQ
https://testcontainers-python.readthedocs.io/en/latest/redis/README.html - for Redis
As a result, there will be no need for the docker-compose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.