Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improving UX of command line #628

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ipcjs
Copy link

@ipcjs ipcjs commented Apr 11, 2024

  1. Support overriding configurational properties in the command line.
  2. The enexSources parameter supports a mixture of multiple files and folders.

For example:

npx -p yarle-evernote-to-md@latest yarle \
  --configFile ./config.json \
  --enexSources ./test-template.enex \
  --outputDir out-new \
  --no-skipWebClips

Relative to #618, #540, #464

@ipcjs ipcjs changed the title wip: add nestedNotebookSeparator & support dir & support cmd args perf: Improving UX of command line Apr 11, 2024
@ipcjs ipcjs marked this pull request as ready for review April 11, 2024 17:38
@ipcjs
Copy link
Author

ipcjs commented Apr 18, 2024

@akosbalasko can you help me review the PR?

@ipcjs
Copy link
Author

ipcjs commented Apr 26, 2024

any update?

@ipcjs
Copy link
Author

ipcjs commented Aug 21, 2024

@akosbalasko Is there anything that needs to be improved in this PR?

@akosbalasko
Copy link
Owner

hi @ipcjs !

First of all, thanks for raising this PR, and apologies for this long silence from my side!

The PR itself looks fine, but could you please proof the correctness by adding some unit tests?

Thanks a lot!

@ipcjs
Copy link
Author

ipcjs commented Aug 22, 2024

I have added two unit test cases.👌

@bumper314
Copy link
Contributor

I would like to have this feature, it would make testing much easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants