Skip to content

Commit

Permalink
Merge pull request #219 from alan-turing-institute/pr-template-update
Browse files Browse the repository at this point in the history
PR template update
  • Loading branch information
KristinaUlicna authored Sep 8, 2023
2 parents e6f6daa + 1cc13e2 commit 488f60b
Showing 1 changed file with 21 additions and 21 deletions.
42 changes: 21 additions & 21 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,28 @@

### What should a reviewer concentrate their feedback on?

- [ ] 🏃 Scripts / notebooks to run
- [ ] 💻 Code quality
- [ ] ✍🏻 Spell check
- [ ] 📝 Everything looks OK?
+ 🏃 Scripts / notebooks to run
+ 💻 Code quality
+ ✍🏻 Spell check
+ 📝 Everything looks OK?


#### What type of PR is this? (check all applicable)

- [ ] 🪄 Feature
- [ ] 🐛 Bug fix
- [ ] 📝 Documentation / update README.md
- [ ] #️⃣ Documentation / code annotation
- [ ] 🧑‍💻 Code refactor / style
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
+ 🪄 Feature
+ 🐛 Bug fix
+ 📝 Documentation / update README.md
+ #️⃣ Documentation / code annotation
+ 🧑‍💻 Code refactor / style
+ 🔥 Performance Improvements
+ ✅ Test


#### Added tests?

- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need some help
+ 👍 yes
+ 🙅 no, because they aren't needed
+ 🙋 no, because I need some help

---

Expand All @@ -47,14 +47,14 @@ Describe what this PR does & **how you reviewed** the individual items, where ne

*Some helper checks to tick off:*

- [ ] Focus on image annotation
- [ ] Focus on model training
- [ ] Could any optimization be applied?
- [ ] Is there any redundant code?
- [ ] Are there any spelling errors?
* Focus on image annotation
* Focus on model training
* Could any optimization be applied?
* Is there any redundant code?
* Are there any spelling errors?


**In conclusion**, after my review, I'd like to:

- [ ] 🙋 ask some clarifying questions
- [ ] 🙅 suggest some specific changes
* 🙋 ask some clarifying questions
* 🙅 suggest some specific changes

0 comments on commit 488f60b

Please sign in to comment.