Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch the classifier training #114

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Launch the classifier training #114

merged 7 commits into from
Jul 27, 2023

Conversation

KristinaUlicna
Copy link
Collaborator

PR to enable GCN classifier training.

@KristinaUlicna KristinaUlicna self-assigned this Jul 3, 2023
@KristinaUlicna KristinaUlicna added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 3, 2023
@KristinaUlicna KristinaUlicna added this to the 0.2 milestone Jul 3, 2023
@KristinaUlicna KristinaUlicna requested review from mooniean and removed request for quantumjot July 11, 2023 13:10
Copy link
Collaborator

@mooniean mooniean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

With the extra instructions, it works. I tried training both a resnet152 and a resnet18 and both worked and trained.

Copy link
Collaborator

@mooniean mooniean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to press approve

Copy link
Collaborator

@chris-soelistyo chris-soelistyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just have a few comments

grace/models/classifier.py Outdated Show resolved Hide resolved
grace/models/classifier.py Outdated Show resolved Hide resolved
grace/models/datasets.py Outdated Show resolved Hide resolved
@quantumjot
Copy link
Collaborator

@chris-soelistyo - I would go ahead and merge this if you're happy with it

@chris-soelistyo chris-soelistyo merged commit 69f3ab6 into main Jul 27, 2023
1 check passed
@chris-soelistyo chris-soelistyo deleted the classifier branch July 27, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
4 participants