-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch the classifier training #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
With the extra instructions, it works. I tried training both a resnet152 and a resnet18 and both worked and trained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to press approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just have a few comments
@chris-soelistyo - I would go ahead and merge this if you're happy with it |
PR to enable GCN classifier training.
val_fraction
totrain_fraction
argument, which is what it isignore_fraction
tokeep_patch_fraction
argument, which is what it is[8, 16, 32, 64]
- resolves [FEATURE REQUEST] Let GCN classifier accept a list of hidden layers #109