Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualisation of the image & graph annotations #149

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

KristinaUlicna
Copy link
Collaborator

@KristinaUlicna KristinaUlicna commented Aug 23, 2023

When reviewing, please annotate an image in napari & then visualise it using the read_grace.ipynb notebook

Data processing:

Plotting / visualisation:

  • Visualise the grace annotations overlaid on the image.
  • Display a montage & average image per classifier training class.
  • Plots simple graph & identifies isolated objects (i.e. connected components)

Graph analysis:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KristinaUlicna KristinaUlicna marked this pull request as draft August 23, 2023 10:50
@KristinaUlicna KristinaUlicna marked this pull request as ready for review August 23, 2023 15:10
@KristinaUlicna KristinaUlicna marked this pull request as draft August 23, 2023 17:52
@KristinaUlicna KristinaUlicna self-assigned this Aug 24, 2023
@KristinaUlicna KristinaUlicna added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Aug 24, 2023
@KristinaUlicna KristinaUlicna marked this pull request as ready for review August 24, 2023 16:20
@KristinaUlicna
Copy link
Collaborator Author

Apologies for a seemingly massive PR, but all the changes are related to the visualisation / annotation update.
This PR needs to go in before metrics can be evaluated. Happy to discuss 🚀

Copy link
Collaborator

@mooniean mooniean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some comments, but everything was running!

grace/evaluation/visualisation.py Outdated Show resolved Hide resolved
grace/evaluation/visualisation.py Outdated Show resolved Hide resolved
grace/evaluation/visualisation.py Outdated Show resolved Hide resolved
@KristinaUlicna
Copy link
Collaborator Author

made some comments, but everything was running!

@mooniean Could you comment on what you did / run to review? It's a significant PR with important data processing, I'd like to make sure it was checked correctly.

@mooniean
Copy link
Collaborator

mooniean commented Sep 5, 2023

made some comments, but everything was running!

@mooniean Could you comment on what you did / run to review? It's a significant PR with important data processing, I'd like to make sure it was checked correctly.

I've done the requested steps: opened image, annotated in napari, loaded it with read_grace.ipynb and ran the whole notebook. Everything was working, the correct things were being shown (apart from the graph being transposed without the image)

@KristinaUlicna KristinaUlicna merged commit 2678703 into main Sep 6, 2023
1 check passed
@KristinaUlicna KristinaUlicna deleted the visualisation branch September 6, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
2 participants