Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise all classifier training code into training subfolder #160

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

KristinaUlicna
Copy link
Collaborator

@KristinaUlicna KristinaUlicna commented Aug 24, 2023

Tidying up the repo. Title is self-explanatory.

When reviewing, please train a model using the run.py script & check that the run completes. Load the Tensorboad view to verify.

@KristinaUlicna
Copy link
Collaborator Author

BTW @chris-soelistyo & @mooniean:

Is there a reason why we're keeping the notebooks run.ipynb & train_and_infer.ipynb?

If not, I'm ready to remove them. LMK if the code / functionality needs to be preserved somewhere else.

@KristinaUlicna KristinaUlicna self-assigned this Aug 24, 2023
@KristinaUlicna KristinaUlicna added the documentation Improvements or additions to documentation label Aug 24, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@chris-soelistyo chris-soelistyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

  • Ran with config, finished training.

@KristinaUlicna KristinaUlicna merged commit 826daba into main Aug 31, 2023
1 check passed
@KristinaUlicna KristinaUlicna deleted the subfolder branch August 31, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all loose training code into a training subfolder Remove the notebooks
2 participants