Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config hyperparameters for enhanced training #273

Merged
merged 8 commits into from
Sep 29, 2023
Merged

Conversation

KristinaUlicna
Copy link
Collaborator

@KristinaUlicna KristinaUlicna commented Sep 29, 2023

PR contribution summary

Why is this PR useful / good for? Please describe the problem(s) you're trying to address.

  • Includes weight decay + learning rate scheduler options
  • Pretty-prints the epoch logging for easier legibility

List of proposed changes / linked issues & discussions

What should a reviewer concentrate their feedback on?

  • 🏃 Test multiple runs with different config params (esp. scheduler)
  • 💻 Code quality

What type of PR is this? (check all applicable)

  • 🪄 Feature
  • #️⃣ Documentation / code annotation
  • 🧑‍💻 Code refactor / style
  • 🔥 Performance Improvements

Added tests?

  • 🙅 no, because they aren't needed

PR review summary

Describe what this PR does & how you reviewed the individual items, where needed:

Some helper checks to tick off:

  • Focus on image annotation
  • Focus on model training
  • Could any optimization be applied?
  • Is there any redundant code?
  • Are there any spelling errors?

In conclusion, after my review, I'd like to:

  • 🙋 ask some clarifying questions
  • 🙅 suggest some specific changes

@KristinaUlicna KristinaUlicna self-assigned this Sep 29, 2023
@KristinaUlicna KristinaUlicna added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 29, 2023
@KristinaUlicna KristinaUlicna changed the base branch from main to development September 29, 2023 14:24
Copy link
Collaborator

@crangelsmith crangelsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KristinaUlicna KristinaUlicna merged commit ee85a0c into development Sep 29, 2023
1 check passed
@KristinaUlicna KristinaUlicna deleted the scheduler branch September 29, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customise the logger to print epochs into new lines [FEATURE REQUEST] Implement enhanced training hparams
2 participants