Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching roc_auc_score error 🚫 #316

Closed
wants to merge 5 commits into from
Closed

Catching roc_auc_score error 🚫 #316

wants to merge 5 commits into from

Conversation

KristinaUlicna
Copy link
Collaborator

PR contribution summary

Why is this PR useful / good for? Please describe the problem(s) you're trying to address.

  • With small random graphs / poorly performing models, it may happen that there is only one class in y_true.
  • This PR implements a safe version of the roc_auc_score function from sklearn which catches this exception.
  • This is especially important for tests (i.e. test_run.py ) to pass.

List of proposed changes / linked issues & discussions

What should a reviewer concentrate their feedback on?

  • 💻 Code quality
  • 📝 Everything looks OK?

What type of PR is this? (check all applicable)

  • 🐛 Bug fix
  • 🧑‍💻 Code refactor / style
  • 🔥 Performance Improvements
  • ✅ Test

Added tests?

  • 🙅 no, but caught an edge case

PR review summary

Describe what this PR does & how you reviewed the individual items, where needed:

Some helper checks to tick off:

  • Focus on image annotation
  • Focus on model training
  • Could any optimization be applied?
  • Is there any redundant code?
  • Are there any spelling errors?

In conclusion, after my review, I'd like to:

  • 🙋 ask some clarifying questions
  • 🙅 suggest some specific changes

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KristinaUlicna KristinaUlicna changed the base branch from main to development October 13, 2023 17:28
@KristinaUlicna KristinaUlicna self-assigned this Oct 13, 2023
@KristinaUlicna KristinaUlicna added bug Something isn't working tests Automated testing for stable main branch labels Oct 13, 2023
@KristinaUlicna KristinaUlicna added this to the Merge `dev` -> `main` milestone Oct 13, 2023
@KristinaUlicna KristinaUlicna changed the base branch from development to extractor October 19, 2023 14:51
@KristinaUlicna
Copy link
Collaborator Author

Closing this one & rebasing with edits only relevant to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Automated testing for stable main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Undefined roc_auc_score if only one class present in y_true
1 participant