Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up run.py by separating inference into assessment module 🧹 #317

Closed
wants to merge 15 commits into from

Conversation

KristinaUlicna
Copy link
Collaborator

@KristinaUlicna KristinaUlicna commented Oct 13, 2023

PR contribution summary

Why is this PR useful / good for? Please describe the problem(s) you're trying to address.

  • Clean up of run.py - separate the entire inference procedure into a separate module.

List of proposed changes / linked issues & discussions

What should a reviewer concentrate their feedback on?

  • 💻 Code quality
  • ✍🏻 Spell check

What type of PR is this? (check all applicable)

  • 🪄 Feature
  • 🧑‍💻 Code refactor / style

Added tests?

  • 🙅 no, because they aren't needed

PR review summary

Describe what this PR does & how you reviewed the individual items, where needed:

Some helper checks to tick off:

  • Focus on image annotation
  • Focus on model training
  • Could any optimization be applied?
  • Is there any redundant code?
  • Are there any spelling errors?

In conclusion, after my review, I'd like to:

  • 🙋 ask some clarifying questions
  • 🙅 suggest some specific changes

@KristinaUlicna KristinaUlicna changed the base branch from development to extractor October 13, 2023 17:32
@KristinaUlicna KristinaUlicna changed the base branch from extractor to development October 13, 2023 17:32
@KristinaUlicna KristinaUlicna changed the title Tidy up run.py by separating inference into assessment module Tidy up run.py by separating inference into assessment module 🧹 Oct 13, 2023
@KristinaUlicna KristinaUlicna self-assigned this Oct 13, 2023
@KristinaUlicna KristinaUlicna added the enhancement New feature or request label Oct 13, 2023
@KristinaUlicna KristinaUlicna added this to the Merge `dev` -> `main` milestone Oct 13, 2023
@KristinaUlicna KristinaUlicna marked this pull request as draft October 23, 2023 20:06
@KristinaUlicna
Copy link
Collaborator Author

PR got out of sync, but all changes are retained in #331 . Closing this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant