-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up run.py
by separating inference into assessment module 🧹
#317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinaUlicna
changed the title
Tidy up
Tidy up Oct 13, 2023
run.py
by separating inference into assessment module run.py
by separating inference into assessment module 🧹
PR got out of sync, but all changes are retained in #331 . Closing this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contribution summary
Why is this PR useful / good for? Please describe the problem(s) you're trying to address.
run.py
- separate the entire inference procedure into a separate module.List of proposed changes / linked issues & discussions
What should a reviewer concentrate their feedback on?
What type of PR is this? (check all applicable)
Added tests?
PR review summary
Describe what this PR does & how you reviewed the individual items, where needed:
Some helper checks to tick off:
In conclusion, after my review, I'd like to: