-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Laplacian 🌐 #329
Graph Laplacian 🌐 #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KristinaUlicna explained all the changes to me. and I have inspected the code. Also ran this with the attached config file (from @KristinaUlicna ) both using the resent feature extractor and without which would be using the default.
The default extracts the mean and min and max and standard deviation
(format has to be .yaml
which can't be attached here)
PR contribution summary
Why is this PR useful / good for? Please describe the problem(s) you're trying to address.
2 intertwined problems:
feature_extractor.py
config.extractor_fn
isNone
, uses a simple image descriptor (mean, sum, max, min) of the underlaying patch to generate features. Super fast, preferable at the moment.config.extractor_fn
is provided (must be called/path/to/resnetXX.pt
), use it to extract image patch embeddingsgraph_laplacian.py
grace/base.py
)Data.x
attribute (seedatasets.py
)Note: No need to check the rest of the code.
List of proposed changes / linked issues & discussions
What should a reviewer concentrate their feedback on?
run.py
withconfig.extractor_fn
asNone
config.extractor_fn
called/path/to/resnet18.pt
(or any resnet)What type of PR is this? (check all applicable)
Added tests?