Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.hash #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mminhlequang
Copy link

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR.

Pre-launch Checklist

  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making if a test is possible.
  • All existing and new tests are passing.

@mikklfr
Copy link

mikklfr commented Dec 19, 2024

Hello @LuisThein and the rest of the team. 👋
Could you have a look at this PR, it's the one that affects less code.
We also forked and did the same edits as @mminhlequang on our end at my client's company but we would love to have this in upstream if possible.
Thanks!

@koozz koozz requested a review from renefloor January 6, 2025 07:48
@koozz
Copy link
Member

koozz commented Jan 6, 2025

Hi @mminhlequang, could you sign the Developer Certificate of Origin (DCO)? The Details link in the failed requirement explains how you can do that.

Signed-off-by: Minh Le Quang <>
@mminhlequang
Copy link
Author

Hi @mminhlequang, could you sign the Developer Certificate of Origin (DCO)? The Details link in the failed requirement explains how you can do that.

yes I did

@koozz
Copy link
Member

koozz commented Jan 8, 2025

Hi @mminhlequang, could you sign the Developer Certificate of Origin (DCO)? The Details link in the failed requirement explains how you can do that.

yes I did

Seems like the DCO bot does not approve. Could be because there is no email address in the sign-off. Could you provide your email?
If you don't want that, you can use the 'Keep my email addresses private (id+username@users.noreply.github.com)' from your GitHub profile settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants