chore: add loading state to the response of useUser (initial PR, still polishing and testing) #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shenghu-Yang
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson and
linnall
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
moldy530
reviewed
Dec 10, 2024
| @@ -35,6 +39,13 @@ export const useUser = (): UseUserResult => { | |||
| const eoaUser = useMemo(() => { | |||
| if (account.status !== "connected" && account.status !== "reconnecting") { | |||
| return null; | |||
| } else if (account.status == "reconnecting") { | |||
There was a problem hiding this comment.
thanks @moldy530 . I am brand new to ts.
change is on its way.
|
It's always super helpful to include how you tested it in your PR! Feel free to add a video or screenshot that helps illistrate how the fix was made and how you ensure there weren't any regressions. If you aren't sure what or how to test the UI please ping myself, @dphilipson, @moldy530!! |
Shenghu-Yang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR enhances the
useUserhook's type definitions and logic to include a loading state for users while the account is reconnecting. It improves type safety and clarity regarding the user status.Detailed summary
UseUserResulttype to include a loading state.useUserhook.loadingproperty is optional for certain user types.