feat: adds MAv2 client #1212
Draft
feat: adds MAv2 client #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
howydev
approved these changes
Dec 13, 2024
howydev
reviewed
Dec 13, 2024
| "transport" | "account" | "chain" | ||
| >; | ||
|
|
||
| export function createSMAV2SignerAccountClient< |
There was a problem hiding this comment.
nit: don't think we need "Signer" in the param/function name
howydev
force-pushed
the
howy/add-get-nonce
branch
from
a013c85 to
94ebe8d
Compare
howydev
force-pushed
the
linna/mav2-client
branch
from
53bfaa2 to
4883301
Compare
This was referenced Dec 13, 2024
Merged
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
moldy530
reviewed
Dec 13, 2024
| const instance = local070InstanceOptSep; | ||
| const client = instance.getClient().extend(publicActions); | ||
| custom, | ||
| keccak256, |
There was a problem hiding this comment.
'keccak256' is defined but never used.
| keccak256, | ||
| parseEther, | ||
| publicActions, | ||
| toHex, |
There was a problem hiding this comment.
'toHex' is defined but never used.
| parseEther, | ||
| publicActions, | ||
| toHex, | ||
| type Address, |
There was a problem hiding this comment.
'Address' is defined but never used.
| toHex, | ||
| type Address, | ||
| } from "viem"; | ||
| import { privateKeyToAccount } from "viem/accounts"; |
There was a problem hiding this comment.
'privateKeyToAccount' is defined but never used.
|
|
||
| const target = "0x000000000000000000000000000000000000dEaD"; | ||
|
|
||
| const startBalance = await client.getBalance({ |
There was a problem hiding this comment.
'startBalance' is assigned a value but never used.
| address: target, | ||
| }); | ||
|
|
||
| const result2 = provider.sendUserOperation({ |
There was a problem hiding this comment.
'result2' is assigned a value but never used.
howydev
force-pushed
the
howy/add-get-nonce
branch
from
94ebe8d to
ea409dd
Compare
howydev
force-pushed
the
linna/mav2-client
branch
from
d826e90 to
d9aa83d
Compare
howydev
force-pushed
the
howy/add-get-nonce
branch
from
ea409dd to
59baaa4
Compare
howydev
force-pushed
the
howy/add-get-nonce
branch
from
59baaa4 to
c6709ec
Compare
howydev
force-pushed
the
linna/mav2-client
branch
from
d9aa83d to
101c00d
Compare
howydev
force-pushed
the
howy/add-get-nonce
branch
3 times, most recently
from
c6709ec to
6e56cc3
Compare
howydev
force-pushed
the
howy/add-get-nonce
branch
from
6e56cc3 to
1109e77
Compare
howydev
force-pushed
the
howy/add-get-nonce
branch
from
1109e77 to
3e9e0e7
Compare
# Pull Request Checklist - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on renaming and restructuring several ABI files and exports in the smart contracts directory, enhancing clarity and consistency in the codebase. ### Detailed summary - Renamed `MAV2FactoryAbi` to `accountFactoryAbi` in `accountFactoryAbi.ts`. - Renamed `smaV2Abi` to `semiModularAccountBytecodeAbi` in `semiModularAccountBytecodeAbi.ts`. - Renamed `singleSignerValidationAbi` to `singleSignerValidationModuleAbi` in `singleSignerValidationModule.ts`. - Updated import statements to reflect the new names. - Added a new `addresses` export containing various module addresses in `utils.ts`. - Introduced new ABI definitions for `paymasterGuardModule`, `timeRangeModule`, `webauthnValidationModule`, `nativeTokenLimitModule`, and `allowlistModule`. - Added ABI definitions for events and error types in the newly created ABI files. > The following files were skipped due to too many changes: `account-kit/smart-contracts/src/ma-v2/abis/semiModularAccountStorageAbi.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
uses a placeholder signer for now
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a new smart contract account type called `SMAV2Account`, along with its creation function `createSMAV2Account`. It includes types, parameters, and logic for initializing accounts using a bundler client, handling initial owners, and generating account addresses.
### Detailed summary
- Added type `SMAV2Account` for smart contract accounts.
- Introduced type `CreateSMAV2AccountParams` for account creation parameters.
- Implemented `createSMAV2Account` function to create a new account.
- Added logic to handle account initialization and owner address retrieval.
- Utilized `createBundlerClient` for client creation.
- Integrated `standardExecutor` and `multiOwnerMessageSigner` for account functionality.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
- [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- This PR introduces a new module for single signer validation in the `account-kit` smart contracts. It adds functionality for packing signatures and validating user operations, along with defining the ABI for the single signer validation module and related contracts. - Added `PackSignatureParams` type and `packSignature` utility in `utils.ts`. - Created `SingleSignerValidationModule` with metadata and encoding functions in `single-signer-validation/module.ts`. - Implemented `singleSignerMessageSigner` function in `single-signer-validation/signer.ts` for signing operations. - Defined the ABI for `singleSignerValidation` in `abis/singleSignerValidation.ts`. - Added ABI for `MAV2Factory` and `smaV2` in their respective files. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
- [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- This PR focuses on renaming and restructuring various ABI exports and imports in the `account-kit/smart-contracts` project, enhancing clarity and organization in the codebase. - Renamed `MAV2FactoryAbi` to `accountFactoryAbi` in `accountFactoryAbi.ts`. - Renamed `smaV2Abi` to `semiModularAccountBytecodeAbi` in `semiModularAccountBytecodeAbi.ts`. - Renamed `singleSignerValidationAbi` to `singleSignerValidationModuleAbi` in `singleSignerValidationModule.ts`. - Updated import statement in `module.ts` for `singleSignerValidationModuleAbi`. - Added new `addresses` export with various module addresses in `utils.ts`. - Introduced `paymasterGuardModuleAbi` in `paymasterGuardModule.ts`. - Added `timeRangeModuleAbi` in `timeRangeModule.ts`. - Added `webauthnValidationModuleAbi` in `webauthnValidation.ts`. - Added `nativeTokenLimitModuleAbi` in `nativeTokenLimitModule.ts`. - Added `allowlistModuleAbi` in `allowlistModule.ts`. - Introduced `modularAccountAbi` in `modularAccountAbi.ts`. - Introduced `semiModularAccountStorageAbi` in `semiModularAccountStorageAbi.ts`. > The following files were skipped due to too many changes: `account-kit/smart-contracts/src/ma-v2/abis/semiModularAccountStorageAbi.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
# Pull Request Checklist - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces several new smart contract ABIs and address constants for a modular account system, enhancing functionality for various modules, including validation and execution. ### Detailed summary - Added `addresses` constant with various module addresses in `addresses.ts`. - Introduced ABIs for `paymasterGuardModule`, `timeRangeModule`, `webauthnValidation`, `nativeTokenLimitModule`, `allowlistModule`, and `maV2`. - Each ABI includes functions, events, and errors relevant to their respective modules. > The following files were skipped due to too many changes: `account-kit/smart-contracts/src/ma-v2/abis/smaStorage.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
linnall
force-pushed
the
howy/add-get-nonce
branch
from
3e9e0e7 to
840636a
Compare
linnall
force-pushed
the
linna/mav2-client
branch
from
101c00d to
5b3c0b0
Compare
7 tasks
howydev
force-pushed
the
howy/add-get-nonce
branch
6 times, most recently
from
d7346a7 to
72a46ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces the
createSMAV2AccountClientfunction, enhancing the smart account client functionality by allowing the creation of a MAv2 account client with specified configuration parameters. It also updates the related test file to reflect these changes.Detailed summary
createSMAV2AccountClientfunction to create a MAv2 account client.CreateSMAV2AccountClientParamstype for client configuration.createSMAV2AccountClientand improve the test structure.