feat: add install/uninstall validation #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
howydev
force-pushed
the
howy/add-install-validation
branch
from
aaff62a to
9e5c594
Compare
Zer0dot
reviewed
Dec 15, 2024
Zer0dot
reviewed
Dec 15, 2024
| ); | ||
| } | ||
|
|
||
| if (validationConfig.entityId === 0) { |
There was a problem hiding this comment.
Mental note for ourselves: This is only the case for SMAb
howydev
force-pushed
the
howy/add-install-validation
branch
from
9e5c594 to
65965de
Compare
howydev
changed the title
howydev
force-pushed
the
howy/add-install-validation
branch
from
74e34e6 to
759c516
Compare
howydev
force-pushed
the
howy/scaffold-v0.8
branch
3 times, most recently
from
f46ac29 to
e09b3f3
Compare
howydev
force-pushed
the
howy/add-install-validation
branch
from
759c516 to
8f31eb6
Compare
howydev
force-pushed
the
howy/add-install-validation
branch
from
8f31eb6 to
a82e838
Compare
howydev
force-pushed
the
howy/scaffold-v0.8
branch
from
e09b3f3 to
d481ee9
Compare
howydev
force-pushed
the
howy/add-install-validation
branch
3 times, most recently
from
cbf1d53 to
be95010
Compare
howydev
force-pushed
the
howy/add-install-validation
branch
from
873b19e to
5f23c26
Compare
howydev
force-pushed
the
howy/scaffold-v0.8
branch
from
0bfcc59 to
7df9b5b
Compare
howydev
force-pushed
the
howy/add-install-validation
branch
from
5f23c26 to
57a194e
Compare
howydev
force-pushed
the
howy/add-install-validation
branch
from
57a194e to
67d0863
Compare
howydev
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
linnall
as code owners
howydev
force-pushed
the
howy/add-install-validation
branch
from
d161f12 to
4e59a6f
Compare
moldy530
reviewed
Dec 20, 2024
|
|
||
| import { createSMAV2AccountClient } from "./client.js"; | ||
|
|
||
| import { createSMAV2AccountClient, type SMAV2AccountClient } from "./client.js"; |
There was a problem hiding this comment.
'SMAV2AccountClient' is defined but never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: fix inconsistency between entityId types - we use
bigints somewhere andnumbers in other placesPR-Codex overview
This PR introduces the
EntityIdOverrideErrorclass to handle cases where an entity ID is invalid due to overriding the owner's entity ID. Additionally, it adds new types and utilities for validation configurations and modifies several functions to integrate these changes.Detailed summary
EntityIdOverrideErrorclass inclient.tsto signify invalid entity ID overrides.DEFAULT_OWNER_ENTITY_IDconstant.ValidationConfig,HookConfig, andModuleEntitytypes intypes.ts.SMAV2AccountClient.