Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds time range module #1227

Closed
wants to merge 8 commits into from

Conversation

linnall
Copy link
Collaborator

@linnall linnall commented Dec 17, 2024

Pull Request Checklist


PR-Codex overview

This PR introduces the TimeRangeModule, which provides functionality to manage time-based validation in a smart contract environment. It includes methods for encoding installation and uninstallation data, and integrates this module into the existing testing framework.

Detailed summary

  • Added TimeRangeModule with metadata and ABI.
  • Implemented encodeOnInstallData, encodeOnUninstallData, and encodeSetTimeRange methods.
  • Updated tests to include installation and uninstallation of the TimeRangeModule.
  • Verified the use of valid time ranges during the installation process.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:31pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:31pm

Copy link

graphite-app bot commented Dec 17, 2024

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@linnall linnall changed the base branch from howy/add-install-validation to linna/paymaster-guard-module December 19, 2024 00:14
@linnall
Copy link
Collaborator Author

linnall commented Dec 20, 2024

closing this pr because the commit history is a mess. changes have been moved to #1253

@linnall linnall closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant