feat: add OTP authentication capabilities to RN Signer #1231
+243
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
iykazrji
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson and
linnall
as code owners
moldy530
reviewed
Dec 17, 2024
| useEffect(() => { | ||
| // get the user if already logged in | ||
| signer.getAuthDetails().then(setUser); | ||
| }, []); |
There was a problem hiding this comment.
React Hook useEffect has a missing dependency: 'signer'. Either include it or remove the dependency array.
moldy530
approved these changes
Dec 18, 2024
linnall
pushed a commit
that referenced
this pull request
Dec 20, 2024
* feat: add OTP authentication capabilities to RN Signer * fix: update redirect route path * fix: fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on enhancing the navigation structure and authentication process in the
rn-signerexample. It introduces a singleton pattern for theRNAlchemySignerand updates the navigation to use bottom tabs, along with modifications to the authentication flow.Detailed summary
@react-navigation/bottom-tabsdependency.redirect-server/index.ts.RNAlchemySignertoRNAlchemySignerSingletonfor singleton implementation.App.tsxto usecreateBottomTabNavigator.MagicLinkAuthScreenandOtpAuthScreenfor authentication.HomeScreentoMagicLinkAuthScreen.otp-auth.tsx.Screenshots
Uploading screen-20241217-170256.mp4…