Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Allowlist Module And Native Token Limit Module #1232

Merged
merged 13 commits into from
Dec 21, 2024

Conversation

Zer0dot
Copy link
Collaborator

@Zer0dot Zer0dot commented Dec 17, 2024

Pull Request Checklist

Implements features related to the AllowlistModule. TODOS:

  • Implement encoding helpers for onInstall() and onUninstall()
  • Test installation and uninstallation
  • Test functionality

PR-Codex overview

This PR focuses on introducing new error handling and validation modules in a smart contract system, enhancing the encoding and decoding of data for various modules, and improving test coverage for these functionalities.

Detailed summary

  • Renamed name in EntityIdOverrideError to "EntityIdOverrideError".
  • Added nativeTokenLimitModule with encoding methods for install/uninstall data.
  • Introduced allowlistModule with encoding methods for install/uninstall data.
  • Updated tests to include scenarios for allowlistModule and nativeTokenLimitModule.
  • Improved error handling for entity ID validation in installValidationActions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 1:03am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 1:03am

Copy link

graphite-app bot commented Dec 17, 2024

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@Zer0dot Zer0dot force-pushed the zer0dot/module-allowlist branch from 57f79ec to 5496c55 Compare December 17, 2024 22:31
@howydev howydev force-pushed the howy/add-install-validation branch 6 times, most recently from d9c40ed to 873b19e Compare December 18, 2024 19:58
@Zer0dot Zer0dot force-pushed the zer0dot/module-allowlist branch from 5496c55 to 52071ce Compare December 18, 2024 20:07
@Zer0dot Zer0dot force-pushed the zer0dot/module-allowlist branch from 52071ce to afccbd9 Compare December 18, 2024 21:17
@Zer0dot Zer0dot changed the base branch from howy/add-install-validation to howy/add-mav2-uo-call-encoding December 18, 2024 21:17
@Zer0dot Zer0dot changed the title feat: Implement Allowlist Module feat: Implement Allowlist Module And Native Token Limit Module Dec 18, 2024
@Zer0dot Zer0dot marked this pull request as draft December 18, 2024 23:10
Copy link
Contributor

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Zer0dot Zer0dot merged commit 5006300 into howy/scaffold-v0.8 Dec 21, 2024
2 of 6 checks passed
@Zer0dot Zer0dot deleted the zer0dot/module-allowlist branch December 21, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants