feat: Add Native Token Limit Module Support #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Zer0dot
force-pushed
the
zer0dot/module-allowlist
branch
from
5496c55 to
52071ce
Compare
Zer0dot
force-pushed
the
zer0dot/module-native-token-limit
branch
from
8d1ac53 to
c9f2990
Compare
Zer0dot
force-pushed
the
zer0dot/module-allowlist
branch
from
52071ce to
afccbd9
Compare
Zer0dot
force-pushed
the
zer0dot/module-native-token-limit
branch
from
c9f2990 to
7ee80c8
Compare
moldy530
reviewed
Dec 18, 2024
| import { getDefaultSingleSignerValidationModuleAddress } from "../modules/utils.js"; | ||
| import { | ||
| getDefaultSingleSignerValidationModuleAddress, | ||
| getDefaultAllowlistModuleAddress, |
There was a problem hiding this comment.
'getDefaultAllowlistModuleAddress' is defined but never used.
There was a problem hiding this comment.
Will address in the relevant pr!
Zer0dot
changed the title
moldy530
reviewed
Dec 18, 2024
| import { getDefaultSingleSignerValidationModuleAddress } from "../modules/utils.js"; | ||
| import { | ||
| getDefaultSingleSignerValidationModuleAddress, | ||
| getDefaultAllowlistModuleAddress, |
There was a problem hiding this comment.
'getDefaultAllowlistModuleAddress' is defined but never used.
Zer0dot
requested review from
rthomare,
dancoombs,
mokok123,
dphilipson and
linnall
as code owners
Zer0dot
added a commit
that referenced
this pull request
Dec 20, 2024
* feat: (WIP) native token limit module support * feat: adapt native token limit module to new arch and add tests * chore: autogenerated file * chore: cleanup
Zer0dot
added a commit
that referenced
this pull request
Dec 20, 2024
* feat: (WIP) native token limit module support * feat: adapt native token limit module to new arch and add tests * chore: autogenerated file * chore: cleanup
Zer0dot
added a commit
that referenced
this pull request
Dec 21, 2024
* feat: (WIP) native token limit module support * feat: adapt native token limit module to new arch and add tests * chore: autogenerated file * chore: cleanup
Zer0dot
added a commit
that referenced
this pull request
Dec 21, 2024
* feat: allowlist module installation and uninstallation * feat: Add Native Token Limit Module Support (#1233) * feat: (WIP) native token limit module support * feat: adapt native token limit module to new arch and add tests * chore: autogenerated file * chore: cleanup * chore: remove only test specifier * test: test allowlist module usage * test: flesh out native token limit module test * chore: rebase fixes * fix: await useroperation results correctly * chore: remove redundant post hook * feat: allow hooks on the fallback validation * fix: fix error name mismatch * fix: remove unnecessary await wrapping * chore: removed unused module components, cleanup * chore: rearrange tests to handle polluted end states
howydev
pushed a commit
that referenced
this pull request
Jan 2, 2025
* feat: allowlist module installation and uninstallation * feat: Add Native Token Limit Module Support (#1233) * feat: (WIP) native token limit module support * feat: adapt native token limit module to new arch and add tests * chore: autogenerated file * chore: cleanup * chore: remove only test specifier * test: test allowlist module usage * test: flesh out native token limit module test * chore: rebase fixes * fix: await useroperation results correctly * chore: remove redundant post hook * feat: allow hooks on the fallback validation * fix: fix error name mismatch * fix: remove unnecessary await wrapping * chore: removed unused module components, cleanup * chore: rearrange tests to handle polluted end states
howydev
pushed a commit
that referenced
this pull request
Jan 2, 2025
* feat: allowlist module installation and uninstallation * feat: Add Native Token Limit Module Support (#1233) * feat: (WIP) native token limit module support * feat: adapt native token limit module to new arch and add tests * chore: autogenerated file * chore: cleanup * chore: remove only test specifier * test: test allowlist module usage * test: flesh out native token limit module test * chore: rebase fixes * fix: await useroperation results correctly * chore: remove redundant post hook * feat: allow hooks on the fallback validation * fix: fix error name mismatch * fix: remove unnecessary await wrapping * chore: removed unused module components, cleanup * chore: rearrange tests to handle polluted end states
howydev
pushed a commit
that referenced
this pull request
Jan 2, 2025
* feat: allowlist module installation and uninstallation * feat: Add Native Token Limit Module Support (#1233) * feat: (WIP) native token limit module support * feat: adapt native token limit module to new arch and add tests * chore: autogenerated file * chore: cleanup * chore: remove only test specifier * test: test allowlist module usage * test: flesh out native token limit module test * chore: rebase fixes * fix: await useroperation results correctly * chore: remove redundant post hook * feat: allow hooks on the fallback validation * fix: fix error name mismatch * fix: remove unnecessary await wrapping * chore: removed unused module components, cleanup * chore: rearrange tests to handle polluted end states
howydev
added a commit
that referenced
this pull request
Jan 2, 2025
* feat: add ma v2 scaffolding with basic uo test * fix: review fixes * fix: some review fixes * fix: more review fixes * chore: rename abi files for clarity * chore: more fixes * chore: more fixes * chore: update abi types * chore: removing arbsepo instance * fix: more review fixes * fix: review fixes, improve getNonce implementation to be more friendly * chore: update sma type to include entity properties * fix: review fixes * fix: type in docs * fix: x * fix: reviews * feat: add install/uninstall validation (#1221) * feat: add install validation, add tests for session key * fix: lint * fix: review fixes * fix: tests * feat: add view functions and user op calldata encodings (#1223) * feat: add paymaster guard module fix: lint fix: review fixes feat: add view functions and user op calldata encodings feat: add paymaster guard module impl feat: adds tests for paymaster guard module chore: clean up comments refactor: removes unnecessary .resolves.not.toThrowError() fix: removes value field from encodeAbiParameters args Co-authored-by: howydev <132113803+howydev@users.noreply.github.com> * feat: adds time range module fix: lint fix: review fixes feat: add view functions and user op calldata encodings feat: adds time module impl feat: adds time range module tests refactor: removes use of addresses, meta, and value field in args passed to encodeAbiParameters Co-authored-by: howydev <132113803+howydev@users.noreply.github.com> * feat: Implement Allowlist Module And Native Token Limit Module (#1232) * feat: allowlist module installation and uninstallation * feat: Add Native Token Limit Module Support (#1233) * feat: (WIP) native token limit module support * feat: adapt native token limit module to new arch and add tests * chore: autogenerated file * chore: cleanup * chore: remove only test specifier * test: test allowlist module usage * test: flesh out native token limit module test * chore: rebase fixes * fix: await useroperation results correctly * chore: remove redundant post hook * feat: allow hooks on the fallback validation * fix: fix error name mismatch * fix: remove unnecessary await wrapping * chore: removed unused module components, cleanup * chore: rearrange tests to handle polluted end states * feat: add native signer, implement signMessage and signTypedData (#1246) * feat: add native signer, implement signMessage and signTypedData * chore: fix --------- Co-authored-by: Linna <38363056+linnall@users.noreply.github.com> Co-authored-by: Zer0dot <zer0dot.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on updating the handling of
entityIdtypes fromnumbertobigint, introducing thenativeTokenLimitModule, and enhancing testing scenarios for module installations and validations.Detailed summary
entityIdtype fromnumbertobigintinInvalidEntityIdError.throw new EntityIdOverrideError()inclient.ts.nativeTokenLimitModulewithencodeOnInstallDataandencodeOnUninstallDatamethods.nativeTokenLimitModule.