Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keeping otp input in view while the code is validated #1234

Closed
wants to merge 2 commits into from

Conversation

jcaleb4
Copy link
Collaborator

@jcaleb4 jcaleb4 commented Dec 18, 2024

Pull Request Checklist

Task: https://app.asana.com/0/1205598840815267/1208982122598661/f
Change: Removing the "otp_completing" view step to keep the OTP input field in view while the validation happens.
On error the message will be shown bellow the input field.
On new focus after error, the error state will reset so the user can try again.
When the last value is set into the input, the input is disabled to prevent changes while validating.


PR-Codex overview

This PR focuses on removing the otp_completing step from the authentication flow and refactoring the LoadingOtp component to handle OTP input more effectively. It also simplifies the handling of authentication errors and success states.

Detailed summary

  • Removed otp_completing case from various components.
  • Updated setValue function in LoadingOtp to handle OTP input.
  • Introduced isDisabled state in LoadingOtp to manage input state.
  • Refactored error handling in LoadingOtp for better clarity.
  • Eliminated CompletingOtp component entirely.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ❌ Failed (Inspect) Dec 18, 2024 4:38pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 4:38pm

Copy link

graphite-app bot commented Dec 18, 2024

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@jcaleb4 jcaleb4 closed this Dec 19, 2024
@jcaleb4 jcaleb4 deleted the caleb/fix-otp-validation-step branch December 19, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants