Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add otp example to bare rn app #1235

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

iykazrji
Copy link
Collaborator

@iykazrji iykazrji commented Dec 18, 2024

Pull Request Checklist


PR-Codex overview

This PR introduces a new authentication flow using a magic link and OTP in a React Native application. It updates the navigation structure and enhances the HomeScreen and OTPAuthScreen components to accommodate these changes.

Detailed summary

  • Updated redirection URL in index.ts to use magic-link.
  • Added magic-link.tsx for new authentication screen.
  • Modified HomeScreen to support magic link authentication.
  • Renamed MagicLinkAuthScreen to OTPAuthScreen and updated its logic.
  • Introduced new navigation using createBottomTabNavigator in App.tsx.
  • Created otp.tsx for OTP authentication logic.
  • Adjusted styles and state management for new screens and authentication methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 6:53pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 6:53pm

Copy link
Collaborator Author


How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Comment on lines +15 to +17
const signer = RNAlchemySigner({
client: { connection: { apiKey: Config.API_KEY! } },
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this still work within the a specific screen since it always returns a singleton now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, did this to silence a linting warning we were getting since the signer instance is also used in a useEffect

moldy530
moldy530 previously approved these changes Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants