feat(aa-sdk): sdk light client can call the alchemy client #1236

Blu-J · 2024-12-18T18:35:09Z

Pull Request Checklist

Did you add new tests and confirm existing tests pass? (yarn test)
Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
Do your commits follow the Conventional Commits standard?
Does your PR title also follow the Conventional Commits standard?
If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
Did you follow the contribution guidelines?

PR-Codex overview

This PR focuses on enhancing the createLightAccountClient function to support a new return type for the Alchemy transport and introduces a utility function isAlchemyTransport to check transport types.

Detailed summary

Modified the return type of createLightAccountClient to return AlchemySmartAccountClient when the transport is Alchemy.
Added isAlchemyTransport function to determine if the transport is of type AlchemyTransport.
Updated CreateLightAccountClientParams to include AlchemyTransport.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-12-18T18:35:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aa-sdk-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 10, 2025 5:33pm
aa-sdk-ui-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 10, 2025 5:33pm

graphite-app · 2024-12-18T18:35:15Z

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

Blu-J · 2024-12-18T18:38:31Z

account-kit/smart-contracts/src/light-account/clients/client.ts

@@ -67,7 +86,7 @@ export function createLightAccountClient<
 */
 export async function createLightAccountClient(
  params: CreateLightAccountClientParams
-): Promise<SmartAccountClient> {
+): Promise<SmartAccountClient | AlchemySmartAccountClient> {
  const { transport, chain } = params;



I originally called something like this
But the code in

Suggested change

if (isAlchemyTransport(transport)) {

return await createLightAccountAlchemyClient({

...params,

transport,

});

}

Since the code is the same?
Here is the snapshot of current alchemy client, I don't see a difference

oh the difference is that this by default calls createSmartAccountClient and the alchemy calls createAlchemySmartAccountClient they take slightly different config params (createSCAClient takes in a paymasterMiddleware and createAlchemySCAClient takes in a gasManagerConfig or I think just a policyId)

Okay, I'll go down the side of testing the params to check the transport as alchemyTransport

moldy530 · 2024-12-18T18:54:08Z

account-kit/smart-contracts/src/light-account/clients/client.ts

+  params: AlchemyLightAccountClientConfig<TSigner>
+): Promise<
+  AlchemySmartAccountClient<
+    Chain | undefined,
+    LightAccount<TSigner>,
+    LightAccountClientActions<TSigner>
+  >
+>;


oh nice! this is way cleaner than what I was thinking which was adding to the conditional typing in for CreateLightAccountClientParams based on the transport

Had to verify this, and slight variation. Good thing for tests right?

site/pages/reference/account-kit/infra/functions/isAlchemyTransport.mdx

Blu-J · 2024-12-20T15:31:37Z

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app · 2024-12-20T17:14:33Z

Merge activity

Dec 20, 12:14 PM EST: A user added this pull request to the Graphite merge queue.
Jan 7, 11:31 AM EST: A user removed this pull request from the Graphite merge queue.
Jan 10, 12:18 PM EST: A user added this pull request to the Graphite merge queue.
Jan 10, 12:34 PM EST: A user merged this pull request with the Graphite merge queue.

# Pull Request Checklist - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [x] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [x] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [x] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [x] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?  --- ## PR-Codex overview This PR focuses on enhancing the `createLightAccountClient` function to support an `AlchemyTransport`, modifying its return type accordingly. Additionally, it introduces the `isAlchemyTransport` utility to check the transport type. ### Detailed summary - Modified `createLightAccountClient` to return `AlchemySmartAccountClient` when using `AlchemyTransport`. - Added `isAlchemyTransport` function to verify if the transport is an `AlchemyTransport`. - Updated type parameters in `CreateLightAccountClientParams` to include `AlchemyTransport`. - Enhanced documentation for the `createLightAccountClient` function. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

Blu-J commented Dec 18, 2024

View reviewed changes

moldy530 reviewed Dec 18, 2024

View reviewed changes

Blu-J closed this Dec 18, 2024

Blu-J force-pushed the jade/poc-same-client branch from f41c381 to 6ebfca5 Compare December 18, 2024 22:21

vercel bot deployed to Preview – aa-sdk-ui-demo December 18, 2024 22:22 View deployment

vercel bot deployed to Preview – aa-sdk-site December 18, 2024 22:24 View deployment

Blu-J reopened this Dec 18, 2024

vercel bot deployed to Preview – aa-sdk-site December 18, 2024 22:28 View deployment

Blu-J force-pushed the jade/poc-same-client branch from 59af47f to cca9ba3 Compare December 18, 2024 22:32

Blu-J marked this pull request as ready for review December 18, 2024 22:35

Blu-J requested review from rthomare, dancoombs, mokok123, dphilipson and linnall as code owners December 18, 2024 22:35

vercel bot deployed to Preview – aa-sdk-ui-demo December 18, 2024 22:35 View deployment

vercel bot deployed to Preview – aa-sdk-site December 18, 2024 22:37 View deployment

Blu-J commented Dec 18, 2024

View reviewed changes

site/pages/reference/account-kit/infra/functions/isAlchemyTransport.mdx Show resolved Hide resolved

Blu-J mentioned this pull request Dec 20, 2024

test(test-d): add test-d files for vitest typechecking: #1248

Merged

7 tasks

moldy530 approved these changes Dec 20, 2024

View reviewed changes

Blu-J mentioned this pull request Jan 7, 2025

feat(client): multi account light and alchemy consolidation #1264

Merged

7 tasks

Blu-J force-pushed the jade/poc-same-client branch from cca9ba3 to e7bcc56 Compare January 7, 2025 16:37

Blu-J requested review from adamegyed, howydev, Zer0dot and jaypaik as code owners January 7, 2025 16:37

vercel bot deployed to Preview – aa-sdk-ui-demo January 7, 2025 16:48 View deployment

vercel bot deployed to Preview – aa-sdk-site January 7, 2025 16:52 View deployment

Blu-J force-pushed the jade/poc-same-client branch from e7bcc56 to 939f24e Compare January 8, 2025 18:57

vercel bot deployed to Preview – aa-sdk-ui-demo January 8, 2025 19:09 View deployment

vercel bot deployed to Preview – aa-sdk-site January 8, 2025 19:11 View deployment

Blu-J force-pushed the jade/poc-same-client branch from 939f24e to a0fdd71 Compare January 8, 2025 21:31

vercel bot deployed to Preview – aa-sdk-ui-demo January 8, 2025 21:43 View deployment

vercel bot deployed to Preview – aa-sdk-site January 8, 2025 21:45 View deployment

Blu-J force-pushed the jade/poc-same-client branch from a0fdd71 to 22a2e20 Compare January 9, 2025 22:46

vercel bot deployed to Preview – aa-sdk-ui-demo January 9, 2025 22:56 View deployment

vercel bot deployed to Preview – aa-sdk-site January 9, 2025 22:59 View deployment

Blu-J force-pushed the jade/poc-same-client branch from 22a2e20 to cd9053b Compare January 10, 2025 17:19

vercel bot deployed to Preview – aa-sdk-ui-demo January 10, 2025 17:29 View deployment

vercel bot deployed to Preview – aa-sdk-site January 10, 2025 17:33 View deployment

graphite-app bot merged commit cd9053b into main Jan 10, 2025
8 checks passed

graphite-app bot deleted the jade/poc-same-client branch January 10, 2025 17:34

vercel bot deployed to Production – aa-sdk-ui-demo January 10, 2025 17:44 View deployment

vercel bot deployed to Production – aa-sdk-site January 10, 2025 17:46 View deployment

Blu-J mentioned this pull request Jan 10, 2025

feat: add alchemy transport update for the mav2 account client #1271

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(aa-sdk): sdk light client can call the alchemy client #1236

feat(aa-sdk): sdk light client can call the alchemy client #1236

Blu-J commented Dec 18, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 18, 2024 •

edited

Loading

graphite-app bot commented Dec 18, 2024

Blu-J Dec 18, 2024

moldy530 Dec 18, 2024

Blu-J Dec 18, 2024

moldy530 Dec 18, 2024

Blu-J Dec 18, 2024

Blu-J commented Dec 20, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024 •

edited

Loading

+  if (isAlchemyTransport(transport)) {
+    return await createLightAccountAlchemyClient({
+      ...params,
+      transport,
+    });
+  }

feat(aa-sdk): sdk light client can call the alchemy client #1236

feat(aa-sdk): sdk light client can call the alchemy client #1236

Conversation

Blu-J commented Dec 18, 2024 • edited by pr-codex bot Loading

Pull Request Checklist

PR-Codex overview

Detailed summary

vercel bot commented Dec 18, 2024 • edited Loading

graphite-app bot commented Dec 18, 2024

How to use the Graphite Merge Queue

Blu-J Dec 18, 2024

Choose a reason for hiding this comment

moldy530 Dec 18, 2024

Choose a reason for hiding this comment

Blu-J Dec 18, 2024

Choose a reason for hiding this comment

moldy530 Dec 18, 2024

Choose a reason for hiding this comment

Blu-J Dec 18, 2024

Choose a reason for hiding this comment

Blu-J commented Dec 20, 2024 • edited Loading

How to use the Graphite Merge Queue

graphite-app bot commented Dec 20, 2024 • edited Loading

Merge activity

Blu-J commented Dec 18, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 18, 2024 •

edited

Loading

Blu-J commented Dec 20, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024 •

edited

Loading