Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update build workflow to delete unnecessary files before building #1240

Merged
merged 15 commits into from
Jan 7, 2025

Conversation

iykazrji
Copy link
Collaborator

@iykazrji iykazrji commented Dec 19, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on commenting out unused caching steps in the .github/actions/setup/action.yml file to clarify that these caches are not being utilized in the actions.

Detailed summary

  • Commented out the Cache dependencies step, indicating it is not used.
  • Commented out the Cache Gradle step, noting it is also not in use.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 5:03pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 5:03pm

Copy link
Collaborator Author

iykazrji commented Dec 19, 2024


How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iykazrji iykazrji changed the title feat: update metro configs to find hoisted modules feat: update build workflow to delete unnecessary files before building Dec 19, 2024
@moldy530
Copy link
Collaborator

moldy530 commented Jan 6, 2025

looks like we made some changes recently to the on-pr action for clearing out some space so this might not be necessary anymore. We most likely do want to comment out the caching pieces because they don't seem to be getting cached anyways

@iykazrji iykazrji changed the base branch from main to moldy/failing-build January 6, 2025 18:41
@iykazrji iykazrji changed the base branch from moldy/failing-build to main January 6, 2025 18:42
@iykazrji
Copy link
Collaborator Author

iykazrji commented Jan 6, 2025

@moldy530, changed the base to main since moldy/failing-build is quite behind ATP as well as removed the action to remove unneeded files.

@iykazrji iykazrji merged commit d0b0924 into main Jan 7, 2025
7 checks passed
@iykazrji iykazrji deleted the iyk/readd-hoisting branch January 7, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants