Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using enum instead of strings for auth step types #1251

Open
wants to merge 1 commit into
base: caleb/otp-styles
Choose a base branch
from

Conversation

jcaleb4
Copy link
Collaborator

@jcaleb4 jcaleb4 commented Dec 20, 2024

Pull Request Checklist


PR-Codex overview

This PR introduces the AuthStepType enum to standardize the types used in authentication steps throughout the application. It replaces string literals with this enum to improve code maintainability and readability.

Detailed summary

  • Introduced AuthStepType enum in context.ts.
  • Replaced string literals with AuthStepType in various components and hooks.
  • Updated setAuthStep calls to use the new enum values.
  • Ensured consistent type checking across authentication steps.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 6:38pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 6:38pm

Copy link

graphite-app bot commented Dec 20, 2024

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant